[GitHub] [spark] maropu commented on a change in pull request #27511: [SPARK-30765][SQL] Refine base operator abstraction code style

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #27511: [SPARK-30765][SQL] Refine base operator abstraction code style
URL: https://github.com/apache/spark/pull/27511#discussion_r377980896
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
 ##########
 @@ -26,11 +26,12 @@ import org.apache.spark.sql.catalyst.expressions.aggregate.AggregateExpression
 import org.apache.spark.sql.execution.{SparkPlan, UnaryExecNode}
 import org.apache.spark.sql.types.{CalendarIntervalType, DateType, IntegerType, TimestampType}
 
-abstract class WindowExecBase(
-    windowExpression: Seq[NamedExpression],
-    partitionSpec: Seq[Expression],
-    orderSpec: Seq[SortOrder],
-    child: SparkPlan) extends UnaryExecNode {
+abstract class WindowExecBase extends UnaryExecNode {
+  def windowExpression: Seq[NamedExpression]
+
 
 Review comment:
   super nit: I feel its better to avoid this blank line along with the others: https://github.com/apache/spark/pull/27368/files#diff-193703359b7f77e83814f1dece93be5fR28-R31

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org