You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "xuyicheng1995 (via GitHub)" <gi...@apache.org> on 2023/04/01 14:21:50 UTC
[GitHub] [shenyu] xuyicheng1995 opened a new pull request, #4524: [type:fix] fix MemorySafeWindowTinyLFUMap memory leak error
xuyicheng1995 opened a new pull request, #4524:
URL: https://github.com/apache/shenyu/pull/4524
<!-- Describe your PR here; eg. Fixes #issueNo -->
[ISSUE #4475] fix MemorySafeWindowTinyLFUMap memory leak error fix #4475
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang merged pull request #4524: [type:fix] fix MemorySafeWindowTinyLFUMap memory leak error
Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang merged PR #4524:
URL: https://github.com/apache/shenyu/pull/4524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4524: [type:fix] fix MemorySafeWindowTinyLFUMap memory leak error
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4524:
URL: https://github.com/apache/shenyu/pull/4524#issuecomment-1493246949
## [Codecov](https://codecov.io/gh/apache/shenyu/pull/4524?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4524](https://codecov.io/gh/apache/shenyu/pull/4524?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4282651) into [master](https://codecov.io/gh/apache/shenyu/commit/09b236e16bca76c394696cb049569c57eff94f90?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09b236e) will **increase** coverage by `0.00%`.
> The diff coverage is `62.50%`.
```diff
@@ Coverage Diff @@
## master #4524 +/- ##
=========================================
Coverage 68.37% 68.37%
- Complexity 7612 7623 +11
=========================================
Files 1028 1028
Lines 29433 29440 +7
Branches 2665 2663 -2
=========================================
+ Hits 20125 20131 +6
+ Misses 7711 7708 -3
- Partials 1597 1601 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4524?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...henyu/common/cache/MemorySafeWindowTinyLFUMap.java](https://codecov.io/gh/apache/shenyu/pull/4524?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jYWNoZS9NZW1vcnlTYWZlV2luZG93VGlueUxGVU1hcC5qYXZh) | `67.16% <62.50%> (-6.17%)` | :arrow_down: |
... and [10 files with indirect coverage changes](https://codecov.io/gh/apache/shenyu/pull/4524/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] xuyicheng1995 commented on pull request #4524: [type:fix] fix MemorySafeWindowTinyLFUMap memory leak error
Posted by "xuyicheng1995 (via GitHub)" <gi...@apache.org>.
xuyicheng1995 commented on PR #4524:
URL: https://github.com/apache/shenyu/pull/4524#issuecomment-1492985216
@moremind please help me review the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org