You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/27 23:26:01 UTC
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4378: server: Optional destination host when migrate a vm
nvazquez commented on a change in pull request #4378:
URL: https://github.com/apache/cloudstack/pull/4378#discussion_r677864062
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/systemvm/MigrateSystemVMCmd.java
##########
@@ -91,6 +97,10 @@ public Long getStorageId() {
return storageId;
}
+ public Boolean isAutoSelect() {
+ return autoSelect != null ? autoSelect : true;
Review comment:
Minor suggestion: to use `BooleanUtils.toBoolean(autoSelect)` here
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java
##########
@@ -93,6 +99,10 @@ public Long getStoragePoolId() {
return storageId;
}
+ public Boolean isAutoSelect() {
+ return autoSelect != null ? autoSelect : true;
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org