You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/11/18 11:39:31 UTC
[GitHub] jmeter pull request #331: Removed (some more) commented out code
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/331
Removed (some more) commented out code
## Description
Removing more commented out code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter remove_commented_out_code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #331
----
commit b60d1b77903d881465295d56199a93b835b305c4
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-11-18T09:47:23Z
Removed commented out code
----
---
[GitHub] jmeter issue #331: Removed (some more) commented out code
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/331
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=h1) Report
> Merging [#331](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/50d617565ccd626aa3c24881971732b9077f8b35?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #331 +/- ##
============================================
- Coverage 57.84% 57.84% -0.01%
+ Complexity 9938 9937 -1
============================================
Files 1142 1142
Lines 73243 73243
Branches 7281 7281
============================================
- Hits 42370 42368 -2
- Misses 28404 28405 +1
- Partials 2469 2470 +1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/jmeter/util/keystore/JmeterKeyStore.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9rZXlzdG9yZS9KbWV0ZXJLZXlTdG9yZS5qYXZh) | `19.54% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==) | `85.38% <ø> (ø)` | `18 <0> (ø)` | :arrow_down: |
| [...pache/jmeter/samplers/StatisticalSampleSender.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvU3RhdGlzdGljYWxTYW1wbGVTZW5kZXIuamF2YQ==) | `32.05% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [src/core/org/apache/jmeter/util/SSLManager.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9TU0xNYW5hZ2VyLmphdmE=) | `31.86% <ø> (ø)` | `10 <0> (ø)` | :arrow_down: |
| [src/core/org/apache/jmeter/util/JMeterUtils.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9KTWV0ZXJVdGlscy5qYXZh) | `46.71% <ø> (ø)` | `62 <0> (ø)` | :arrow_down: |
| [...he/jmeter/visualizers/backend/BackendListener.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9CYWNrZW5kTGlzdGVuZXIuamF2YQ==) | `10.34% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| [.../core/org/apache/jmeter/samplers/SampleResult.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvU2FtcGxlUmVzdWx0LmphdmE=) | `77.1% <ø> (ø)` | `127 <0> (ø)` | :arrow_down: |
| [...ions/org/apache/jmeter/functions/XPathWrapper.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree#diff-c3JjL2Z1bmN0aW9ucy9vcmcvYXBhY2hlL2ptZXRlci9mdW5jdGlvbnMvWFBhdGhXcmFwcGVyLmphdmE=) | `95.45% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| [...rc/core/org/apache/jmeter/services/FileServer.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2VydmljZXMvRmlsZVNlcnZlci5qYXZh) | `71.21% <ø> (ø)` | `56 <0> (ø)` | :arrow_down: |
| [...pache/jmeter/samplers/SampleSaveConfiguration.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvU2FtcGxlU2F2ZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `68.38% <ø> (ø)` | `95 <0> (ø)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=footer). Last update [50d6175...b60d1b7](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter pull request #331: Removed (some more) commented out code
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/331
---