You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/11/15 04:44:46 UTC

[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #328: [YUNIKORN-938] Admission controller: remove v1beta1 usage

wilfred-s commented on a change in pull request #328:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/328#discussion_r749001468



##########
File path: pkg/plugin/predicates/predicate_manager.go
##########
@@ -23,9 +23,9 @@ import (
 	"fmt"
 
 	"go.uber.org/zap"
+	admissionV1 "k8s.io/api/admission/v1"
 	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/runtime"
-	"k8s.io/kube-scheduler/config/v1beta1"

Review comment:
       This is not related to the admission controller either. This is linked to the plugins. probably should not be part of this change either.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org