You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by li...@apache.org on 2017/10/19 12:14:36 UTC
carbondata git commit: [CARBONDATA-1599] Optimize pull request
template
Repository: carbondata
Updated Branches:
refs/heads/master 0bf597d9e -> 228ab2fd1
[CARBONDATA-1599] Optimize pull request template
Optimize pull request template for reminding contributors to provide full information.
This closes #1422
Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/228ab2fd
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/228ab2fd
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/228ab2fd
Branch: refs/heads/master
Commit: 228ab2fd18514873c930a14c2c039e7efb083020
Parents: 0bf597d
Author: chenliang613 <ch...@apache.org>
Authored: Thu Oct 19 16:55:57 2017 +0530
Committer: lionelcao <wh...@gmail.com>
Committed: Thu Oct 19 20:06:49 2017 +0800
----------------------------------------------------------------------
.github/PULL_REQUEST_TEMPLATE.md | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/carbondata/blob/228ab2fd/.github/PULL_REQUEST_TEMPLATE.md
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 02f17e7..0d9f60c 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -3,17 +3,24 @@ quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[CARBONDATA-<Jira issue #>] Description of pull request`
- - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
- Travis-CI on your fork and ensure the whole test matrix passes).
- - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
- number, if there is one.
- - [ ] If this contribution is large, please file an Apache
- [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
+
+ - [ ] Make sure to add PR description including
+
+ - the root cause/problem statement
+ - What is the implemented solution
+
+ - [ ] Any interfaces changed?
+
+ - [ ] Any backward compatibility impacted?
+
+ - [ ] Document update required?
+
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- - What manual testing you have done?
+ - How it is tested? Please attach test report.
+ - Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.