You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/03 19:44:15 UTC

[GitHub] [geode] jchen21 commented on a change in pull request #5209: GEODE-8211: fix flaky shutdown test

jchen21 commented on a change in pull request #5209:
URL: https://github.com/apache/geode/pull/5209#discussion_r434811874



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -61,11 +61,7 @@ public void shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
 
     // Unfortunately Jedis' shutdown() doesn't seem to throw a JedisDataException when the command
     // returns an error.
-    try {
-      jedis.shutdown();
-    } catch (JedisConnectionException ignore) {

Review comment:
       Will `jedis.shutdown()` no longer throw `JedisConnectionException`? Or if  `JedisConnectionException` is thrown, we just don't want to catch it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org