[GitHub] [dolphinscheduler] chengshiwen commented on a change in pull request #5591: [Fix-5587] [Bug][API] Tenant validation failure under Windows #5587

[GitBox <gi...@apache.org>]

chengshiwen commented on a change in pull request #5591:
URL: https://github.com/apache/dolphinscheduler/pull/5591#discussion_r645928071



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TenantServiceImpl.java
##########
@@ -95,6 +95,11 @@
             return result;
         }
 
+        if (!RegexUtils.isValidWindowUserName(tenantCode)) {

Review comment:
       This logic is not correct, because the username that does not satisfy Linux has been returned, and it is no longer possible to check if it satisfies the username of Windows

##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/RegexUtils.java
##########
@@ -32,14 +32,15 @@
 
     private static final String LINUX_USERNAME_PATTERN = "[a-z_][a-z\\d_]{0,30}";
 
+    private static final String WINDOWS_USERNAME_PATTERN = "[a-z_][a-z\\d_]{0,30}";

Review comment:
       `WINDOWS_USERNAME_PATTERN` is just same with `LINUX_USERNAME_PATTERN`, and not for Windows




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org