You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by cp...@apache.org on 2017/06/06 13:59:38 UTC
lucene-solr:master: SOLR-10671: remove two-and-a-half unused private
static logger warnings
Repository: lucene-solr
Updated Branches:
refs/heads/master ea79c668c -> 622e527cf
SOLR-10671: remove two-and-a-half unused private static logger warnings
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/622e527c
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/622e527c
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/622e527c
Branch: refs/heads/master
Commit: 622e527cf2a05d914a91fd5e6fa0d0255cb68454
Parents: ea79c66
Author: Christine Poerschke <cp...@apache.org>
Authored: Tue Jun 6 14:30:19 2017 +0100
Committer: Christine Poerschke <cp...@apache.org>
Committed: Tue Jun 6 14:40:46 2017 +0100
----------------------------------------------------------------------
.../org/apache/solr/metrics/reporters/SolrGangliaReporter.java | 4 ----
.../org/apache/solr/metrics/reporters/SolrGraphiteReporter.java | 4 ----
.../org/apache/solr/metrics/reporters/SolrSlf4jReporter.java | 3 ++-
3 files changed, 2 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/622e527c/solr/core/src/java/org/apache/solr/metrics/reporters/SolrGangliaReporter.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/metrics/reporters/SolrGangliaReporter.java b/solr/core/src/java/org/apache/solr/metrics/reporters/SolrGangliaReporter.java
index 4dfdbeb..8d87940 100644
--- a/solr/core/src/java/org/apache/solr/metrics/reporters/SolrGangliaReporter.java
+++ b/solr/core/src/java/org/apache/solr/metrics/reporters/SolrGangliaReporter.java
@@ -17,7 +17,6 @@
package org.apache.solr.metrics.reporters;
import java.io.IOException;
-import java.lang.invoke.MethodHandles;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.TimeUnit;
@@ -27,14 +26,11 @@ import com.codahale.metrics.ganglia.GangliaReporter;
import info.ganglia.gmetric4j.gmetric.GMetric;
import org.apache.solr.metrics.SolrMetricManager;
import org.apache.solr.metrics.SolrMetricReporter;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
*
*/
public class SolrGangliaReporter extends SolrMetricReporter {
- private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private String host = null;
private int port = -1;
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/622e527c/solr/core/src/java/org/apache/solr/metrics/reporters/SolrGraphiteReporter.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/metrics/reporters/SolrGraphiteReporter.java b/solr/core/src/java/org/apache/solr/metrics/reporters/SolrGraphiteReporter.java
index b8eddf5..e74bb35 100644
--- a/solr/core/src/java/org/apache/solr/metrics/reporters/SolrGraphiteReporter.java
+++ b/solr/core/src/java/org/apache/solr/metrics/reporters/SolrGraphiteReporter.java
@@ -17,7 +17,6 @@
package org.apache.solr.metrics.reporters;
import java.io.IOException;
-import java.lang.invoke.MethodHandles;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.TimeUnit;
@@ -29,14 +28,11 @@ import com.codahale.metrics.graphite.GraphiteSender;
import com.codahale.metrics.graphite.PickledGraphite;
import org.apache.solr.metrics.SolrMetricManager;
import org.apache.solr.metrics.SolrMetricReporter;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
* Metrics reporter that wraps {@link com.codahale.metrics.graphite.GraphiteReporter}.
*/
public class SolrGraphiteReporter extends SolrMetricReporter {
- private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private String host = null;
private int port = -1;
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/622e527c/solr/core/src/java/org/apache/solr/metrics/reporters/SolrSlf4jReporter.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/metrics/reporters/SolrSlf4jReporter.java b/solr/core/src/java/org/apache/solr/metrics/reporters/SolrSlf4jReporter.java
index 7dfe5bb..e301885 100644
--- a/solr/core/src/java/org/apache/solr/metrics/reporters/SolrSlf4jReporter.java
+++ b/solr/core/src/java/org/apache/solr/metrics/reporters/SolrSlf4jReporter.java
@@ -43,7 +43,8 @@ import org.slf4j.LoggerFactory;
* </ul>
*/
public class SolrSlf4jReporter extends SolrMetricReporter {
- // we need this to pass validate-source-patterns
+
+ @SuppressWarnings("unused") // we need this to pass validate-source-patterns
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private int period = 60;