You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/16 23:34:08 UTC

[GitHub] [tvm] spectrometerHBH edited a comment on pull request #9699: [TIR] Affine utility support freevars, iter lowerbound and diagnostics

spectrometerHBH edited a comment on pull request #9699:
URL: https://github.com/apache/tvm/pull/9699#issuecomment-996275253


   Here are some comments.
   1. Free vars
   I think currently the `DetectIterMap` already supports free var, as long as you don't include the var in the domain map
   2. Add `min` field to `IterMark` class
   Iters with lower bound constraints can be substituted with a zero-starting iter plus offset, I think. If we want to allow non-zero lower bound constraints in predicates, then we may want to loose the check.
   3 & 4 look good to me.
   
   BTW, the case shown in your description is not the same as the case you added in the testcase. I thought you'd like to support the binding after #9527, so you may want to modify the test case, IIUC?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org