You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/02/03 08:13:06 UTC
[GitHub] [kylin] codecov-io commented on issue #1090: KYLIN-4344 Build
Global Dict by MR/Hive, Extract Fact Table Distinct Columns Step
codecov-io commented on issue #1090: KYLIN-4344 Build Global Dict by MR/Hive, Extract Fact Table Distinct Columns Step
URL: https://github.com/apache/kylin/pull/1090#issuecomment-581288624
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1090?src=pr&el=h1) Report
> Merging [#1090](https://codecov.io/gh/apache/kylin/pull/1090?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/33c9f7528e886b1df0ab739648f6ae30bc5c979b?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `1.16%`.
[](https://codecov.io/gh/apache/kylin/pull/1090?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1090 +/- ##
============================================
+ Coverage 25.05% 25.06% +<.01%
Complexity 6223 6223
============================================
Files 1440 1440
Lines 87830 87889 +59
Branches 12275 12286 +11
============================================
+ Hits 22006 22026 +20
- Misses 63666 63704 +38
- Partials 2158 2159 +1
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1090?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/kylin/source/hive/HiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1090/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVJbnB1dEJhc2UuamF2YQ==) | `7.11% <0%> (+0.42%)` | `4 <0> (ø)` | :arrow_down: |
| [...a/org/apache/kylin/source/hive/MRHiveDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1090/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL01SSGl2ZURpY3RVdGlsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1090/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `11.92% <2.85%> (-0.42%)` | `44 <0> (ø)` | |
| [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1090/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
| [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/1090/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `62.24% <0%> (-0.65%)` | `26% <0%> (ø)` | |
| [...che/kylin/source/jdbc/extensible/JdbcExplorer.java](https://codecov.io/gh/apache/kylin/pull/1090/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL2V4dGVuc2libGUvSmRiY0V4cGxvcmVyLmphdmE=) | `67.41% <0%> (+0.37%)` | `13% <0%> (ø)` | :arrow_down: |
| [...ava/org/apache/kylin/source/jdbc/JdbcExplorer.java](https://codecov.io/gh/apache/kylin/pull/1090/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0pkYmNFeHBsb3Jlci5qYXZh) | `36.73% <0%> (+0.43%)` | `11% <0%> (ø)` | :arrow_down: |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1090/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `76.74% <0%> (+2.32%)` | `12% <0%> (ø)` | :arrow_down: |
| [...java/org/apache/kylin/query/util/PushDownUtil.java](https://codecov.io/gh/apache/kylin/pull/1090/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUHVzaERvd25VdGlsLmphdmE=) | `80.48% <0%> (+4.01%)` | `4% <0%> (ø)` | :arrow_down: |
| [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1090/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `94.73% <0%> (+5.26%)` | `7% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1090?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1090?src=pr&el=footer). Last update [33c9f75...05913c4](https://codecov.io/gh/apache/kylin/pull/1090?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services