You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/01 20:16:28 UTC

[GitHub] [superset] megakoresh commented on a change in pull request #13917: Helm: do not run containers as root by default

megakoresh commented on a change in pull request #13917:
URL: https://github.com/apache/superset/pull/13917#discussion_r605920683



##########
File path: helm/superset/values.yaml
##########
@@ -21,15 +21,19 @@
 
 replicaCount: 1
 
-## These requirements are used to build a requirements file which is then applied on init
-## of superset containers
-additionalRequirements:
-  - "psycopg2==2.8.5"
-  - "redis==3.2.1"
-
-## These apt packages are applied on init of superset containers
-additionalAptPackages: {}
-  # - nano
+# User ID directive
+# Note that this user must have appropriate permissions to run the bootstrap script
+runAsUser: 1000
+
+# Install additional packages and do any other bootstrap configuration in this script
+# For production clusters it's recommended to build own image with this step done in CI
+bootstrapScript: |
+  #!/bin/bash

Review comment:
       Yes. I switched default uid to 1000 which will cause these lines to fail if those lines are uncommented. The purpose is to show users that this is a place to perform such tasks, but also that they must make their environment less secure by setting runAsUser value to 0.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org