[jira] [Issue Comment Deleted] (GUACAMOLE-35) Performance flags not handled

["Michael Jumper (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GUACAMOLE-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Jumper updated GUACAMOLE-35:
------------------------------------
    Comment: was deleted

(was: Github user jmuehlner commented on a diff in the pull request:

    https://github.com/apache/incubator-guacamole-server/pull/10#discussion_r64324484
  
    --- Diff: src/protocols/rdp/rdp_settings.c ---
    @@ -925,9 +925,31 @@ void guac_rdp_push_settings(guac_rdp_settings* guac_settings, freerdp* rdp) {
     
         /* Performance flags */
     #ifdef LEGACY_RDPSETTINGS
    +
    +    /* Explicitly set flag value */
         rdp_settings->performance_flags = guac_rdp_get_performance_flags(guac_settings);
    +
    +    /* Set individual flags - some FreeRDP versions overwrite the above */
    +    rdp_settings->smooth_fonts = guac_settings->font_smoothing_enabled;
    +    rdp_settings->disable_wallpaper = !guac_settings->wallpaper_enabled;
    +    rdp_settings->disable_full_window_drag = !guac_settings->full_window_drag_enabled;
    +    rdp_settings->disable_menu_animations = !guac_settings->menu_animations_enabled;
    +    rdp_settings->disable_theming = !guac_settings->theming_enabled;
    +    rdp_settings->desktop_composition = !guac_settings->desktop_composition_enabled;
    --- End diff --
    
    Meaning that you should remove the ! that inverts the setting here?
)

> Performance flags not handled
> -----------------------------
>
>                 Key: GUACAMOLE-35
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-35
>             Project: Guacamole
>          Issue Type: Bug
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>            Priority: Critical
>
> Depending on the version of FreeRDP installed, performance flags specified via connection parameters (such as "enable-wallpaper") are ignored.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)