[GitHub] [superset] suddjian commented on a change in pull request #15715: fix: margin right on warning icon to 8px

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #15715:
URL: https://github.com/apache/superset/pull/15715#discussion_r670786821



##########
File path: superset-frontend/src/components/WarningIconWithTooltip/index.tsx
##########
@@ -35,7 +35,10 @@ function WarningIconWithTooltip({
       id="warning-tooltip"
       title={<SafeMarkdown source={warningMarkdown} />}
     >
-      <Icons.AlertSolid iconColor={theme.colors.alert.base} />
+      <Icons.AlertSolid
+        iconColor={theme.colors.alert.base}
+        css={{ marginRight: `8px` }}

Review comment:
       Let's use grid units.
   ```suggestion
           css={{ marginRight: `${theme.gridUnit * 2}px` }}
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org