You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Phoenix500526 (via GitHub)" <gi...@apache.org> on 2026/09/04 02:04:05 UTC
[PR] fix(desktop): keep Node crypto out of renderer [maka]
Phoenix500526 opened a new pull request, #4705:
URL: https://github.com/apache/maka/pull/4705
## Summary
The Renderer loaded `@maka/runtime-host/protocol`, whose Client Capability
module imported `node:crypto`. Vite externalized that Node-only module in the
browser, and reading `createHash` threw before React mounted, leaving Desktop
stuck on the startup skeleton.
Move the identity hashing helper to an explicit Node-only Runtime Host export
used by Desktop main and CLI. Keep the browser-facing protocol entry free of
that dependency, and add a Vite transformation regression test for the
boundary.
Fixes #4700
## Verification
- `npm --workspace @maka/runtime-host run build`
- `npm --workspace @maka/desktop run build:main`
- `npm --workspace maka-agent run build`
- `npm --workspace @maka/desktop run build:renderer`
- `node --test apps/desktop/scripts/vite-workspace-packages.test.mjs`
- `node --test packages/runtime-host/dist/__tests__/client-capability-protocol.test.js packages/cli/dist/__tests__/cli.test.js`
- `npx biome lint` and `npx biome format` for the changed sources
- `npm run check:asf-headers`
- Manual `npm run dev`: the real Desktop window mounted successfully and its
console contained no startup error
The programmatic real-window smoke reached an existing macOS first-load
`ERR_FAILED` path before it could capture diagnostics; the normal development
startup path above was verified directly.
## AI use
Select exactly one:
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: OpenAI Codex diagnosed the Renderer dependency boundary,
implemented the fix and regression test, and ran the checks listed above.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): keep Node crypto out of renderer [maka]
Posted by "Phoenix500526 (via GitHub)" <gi...@apache.org>.
Phoenix500526 commented on PR #4705:
URL: https://github.com/apache/maka/pull/4705#issuecomment-5534790337
CC @me2seeks @Astro-Han
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): keep Node crypto out of renderer [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #4705:
URL: https://github.com/apache/maka/pull/4705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org