You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sergey-chugunov-1985 (via GitHub)" <gi...@apache.org> on 2023/06/29 14:48:09 UTC

[GitHub] [ignite-3] sergey-chugunov-1985 opened a new pull request, #2269: IGNITE-19883 Patch review general checklist added

sergey-chugunov-1985 opened a new pull request, #2269:
URL: https://github.com/apache/ignite-3/pull/2269

   https://issues.apache.org/jira/browse/IGNITE-19883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2269: IGNITE-19883 Patch review general checklist added

Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 commented on code in PR #2269:
URL: https://github.com/apache/ignite-3/pull/2269#discussion_r1276890911


##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -0,0 +1,20 @@
+Thank you for submitting the pull request.
+
+In order to streamline the review of the patch and ensure better code quality
+we ask both an author and a reviewer to check the following requirements:
+
+### The Review Checklist
+- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also check the following list:  
+\- There is a single JIRA ticket related to the pull request.  
+\- The web-link to the pull request is attached to the JIRA ticket.  
+\- The JIRA ticket has the Patch Available state.  
+\- The description of the JIRA ticket explains WHAT and WHY was made and HOW.  
+\- The JIRA ticket has the Patch Available state.  

Review Comment:
   Please remove this duplicate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ignite-3] sergey-chugunov-1985 closed pull request #2269: IGNITE-19883 Patch review general checklist added

Posted by "sergey-chugunov-1985 (via GitHub)" <gi...@apache.org>.
sergey-chugunov-1985 closed pull request #2269: IGNITE-19883 Patch review general checklist added
URL: https://github.com/apache/ignite-3/pull/2269


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org