You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ariatosca.apache.org by Thomas Nadeau <tn...@gmail.com> on 2018/02/08 14:39:35 UTC

code review for ARIA-118

DJ and I sat down this morning and did a pairwise code review of his patch
set.
The functionally things look cool.  My requests for changes have to do with
adding more comments and transforming literal strings/integers into
constants which have been discussed in detail during our code review. So he
is going to withdraw his PR and amend things a bit and resubmit.

--Tom