You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/06/23 05:07:06 UTC

[GitHub] [submarine] chiajoukuo opened a new pull request #324: Submarine-515. [WEB]Implement Hyper parameters in experiment page.

chiajoukuo opened a new pull request #324:
URL: https://github.com/apache/submarine/pull/324


   ### What is this PR for?
   Implement Hyper parameters in experiment page.
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-515
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   ![螢幕錄製-2020-06-23-下午12 37 39](https://user-images.githubusercontent.com/45503025/85362948-5965a200-b552-11ea-94b4-6252bef6a00d.gif)
   
   ### Questions:
   * Does the licenses files need update? Yes/No
   * Is there breaking changes for older versions? Yes/No
   * Does this needs documentation? Yes/No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kobe860219 commented on pull request #324: SUBMARINE-515. [WEB]Implement Hyper parameters in experiment page.

Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #324:
URL: https://github.com/apache/submarine/pull/324#issuecomment-648602868


   @chiajoukuo Thank for your contribution. It looks good to me :))


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #324: SUBMARINE-515. [WEB]Implement Hyper parameters in experiment page.

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #324:
URL: https://github.com/apache/submarine/pull/324


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] chiajoukuo commented on pull request #324: SUBMARINE-515. [WEB]Implement Hyper parameters in experiment page.

Posted by GitBox <gi...@apache.org>.
chiajoukuo commented on pull request #324:
URL: https://github.com/apache/submarine/pull/324#issuecomment-648228225


   @liuxunorg @jasoonn Thanks for your advice. I have updated my pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on pull request #324: SUBMARINE-515. [WEB]Implement Hyper parameters in experiment page.

Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #324:
URL: https://github.com/apache/submarine/pull/324#issuecomment-649919043


   will commit if no more comments


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] jasoonn commented on a change in pull request #324: Submarine-515. [WEB]Implement Hyper parameters in experiment page.

Posted by GitBox <gi...@apache.org>.
jasoonn commented on a change in pull request #324:
URL: https://github.com/apache/submarine/pull/324#discussion_r444009075



##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/hyper-params/hyper-params.component.html
##########
@@ -17,4 +17,17 @@
   ~ under the License.
   -->
 
-<p>hyper-params works!</p>
+<nz-table #basicTable [nzFrontPagination]="false" [nzData]="paramsList">
+  <thead>
+    <tr>
+      <th>Key</th>
+      <th>Value</th>
+    </tr>
+  </thead>
+  <tbody>
+    <tr *ngFor="let data of basicTable.data">
+      <td>{{data.key}}</td>
+      <td>{{data.value}}</td>
+    </tr>
+  </tbody>
+</nz-table>

Review comment:
       No newline at the end of the file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] chiajoukuo commented on pull request #324: Submarine-515. [WEB]Implement Hyper parameters in experiment page.

Posted by GitBox <gi...@apache.org>.
chiajoukuo commented on pull request #324:
URL: https://github.com/apache/submarine/pull/324#issuecomment-647911334


   @liuxunorg  @kevin85421  @jasoonn  @kobe860219  Can you help me review the pull request? Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org