You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/10/12 22:11:15 UTC
Review Request 26629: Replace cerr/exit with EXIT when parsing master
flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26629/
-----------------------------------------------------------
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Repository: mesos-git
Description
-------
Replace cerr/exit with EXIT when parsing master flags.
Diffs
-----
src/master/main.cpp 72e243a7374be36787a1e5a87d1ff370b8b9d4e0
Diff: https://reviews.apache.org/r/26629/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 26629: Replace cerr/exit with EXIT when parsing
master flags.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26629/#review56363
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26629]
All tests passed.
- Mesos ReviewBot
On Oct. 12, 2014, 8:11 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26629/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2014, 8:11 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace cerr/exit with EXIT when parsing master flags.
>
>
> Diffs
> -----
>
> src/master/main.cpp 72e243a7374be36787a1e5a87d1ff370b8b9d4e0
>
> Diff: https://reviews.apache.org/r/26629/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26629: Replace cerr/exit with EXIT when parsing
master flags.
Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26629/#review56371
-----------------------------------------------------------
LGTM!
- Cody Maloney
On Oct. 12, 2014, 8:11 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26629/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2014, 8:11 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace cerr/exit with EXIT when parsing master flags.
>
>
> Diffs
> -----
>
> src/master/main.cpp 72e243a7374be36787a1e5a87d1ff370b8b9d4e0
>
> Diff: https://reviews.apache.org/r/26629/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26629: Replace cerr/exit with EXIT when parsing
master flags.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26629/#review56825
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 12, 2014, 1:11 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26629/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2014, 1:11 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace cerr/exit with EXIT when parsing master flags.
>
>
> Diffs
> -----
>
> src/master/main.cpp 72e243a7374be36787a1e5a87d1ff370b8b9d4e0
>
> Diff: https://reviews.apache.org/r/26629/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26629: Replace cerr/exit with EXIT when parsing
master flags.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26629/#review56361
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Oct. 12, 2014, 8:11 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26629/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2014, 8:11 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Replace cerr/exit with EXIT when parsing master flags.
>
>
> Diffs
> -----
>
> src/master/main.cpp 72e243a7374be36787a1e5a87d1ff370b8b9d4e0
>
> Diff: https://reviews.apache.org/r/26629/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>