[GitHub] [helix] parakhnr commented on a diff in pull request #2505: Replace deprecated verifier with new set of Verifiers

["parakhnr (via GitHub)" <gi...@apache.org>]

parakhnr commented on code in PR #2505:
URL: https://github.com/apache/helix/pull/2505#discussion_r1204570885


##########
helix-core/src/test/java/org/apache/helix/integration/manager/TestDistributedControllerManager.java:
##########
@@ -71,18 +72,18 @@ public void simpleIntegrationTest() throws Exception {
           new MockMSModelFactory());
       distributedControllers[i].connect();
     }
+    BestPossibleExternalViewVerifier verifier = new BestPossibleExternalViewVerifier
+        .Builder(clusterName).setZkAddress(ZK_ADDR).build();
 
-    boolean result = ClusterStateVerifier
-        .verifyByZkCallback(new BestPossAndExtViewZkVerifier(ZK_ADDR, clusterName));
+    boolean result = verifier.verifyByZkCallback();
     Assert.assertTrue(result);
 
     // disconnect first distributed-controller, and verify second takes leadership
     distributedControllers[0].disconnect();
 
     // verify leader changes to localhost_12919
     Thread.sleep(100);

Review Comment:
   I know this change is just for refactoring but if you want can we use `TestHelper.verify()` instead of using `Thread.sleep()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org