You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "echonesis (via GitHub)" <gi...@apache.org> on 2026/08/17 10:11:32 UTC
[PR] HDDS-16193. Clean up ScmClient [ozone]
echonesis opened a new pull request, #11035:
URL: https://github.com/apache/ozone/pull/11035
## What changes were proposed in this pull request?
`ScmClient` is an internal interface that contains several deprecated or unused methods.
This PR:
- removes the deprecated `createContainer` overload that accepts replication type and factor separately;
- removes unused container creation, deletion, reading, and size methods;
- removes the corresponding implementations and unused configuration fields from `ContainerOperationClient`;
- updates existing test callers to use `ReplicationConfig` explicitly.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16193
## How was this patch tested?
Local Test
```shell
# The Non-HA integration test suite was run with a clean reactor build
mvn -pl :ozone-integration-test -am \
clean test \
-Dtest=TestOzoneIntegrationNonHA \
-Dsurefire.failIfNoSpecifiedTests=false -DskipShade -DskipRecon -DskipDocs -Dscan=false
# The updated container balancer test was also run directly
mvn \
-pl :ozone-integration-test test \
-Dtest=TestContainerBalancerOperations \
-DskipShade -DskipRecon -DskipDocs -Dscan=false
```
GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/32006995899
Generated-by: Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16193. Clean up ScmClient [ozone]
Posted by "echonesis (via GitHub)" <gi...@apache.org>.
echonesis commented on PR #11035:
URL: https://github.com/apache/ozone/pull/11035#issuecomment-5336494346
Thanks @szetszwo for the review, @ivandika3 for the review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16193. Clean up ScmClient [ozone]
Posted by "echonesis (via GitHub)" <gi...@apache.org>.
echonesis commented on code in PR #11035:
URL: https://github.com/apache/ozone/pull/11035#discussion_r3800616403
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java:
##########
@@ -55,13 +54,6 @@
*/
@InterfaceStability.Unstable
Review Comment:
Thanks @ivandika3
Yes, that makes sense. `ScmClient` is an internal Ozone/SCM abstraction rather than a supported public client API. Since it is already marked `Unstable`, adding `InterfaceAudience.Private` makes the existing contract explicit. I’ll add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16193. Clean up ScmClient [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on code in PR #11035:
URL: https://github.com/apache/ozone/pull/11035#discussion_r3800218494
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java:
##########
@@ -55,13 +54,6 @@
*/
@InterfaceStability.Unstable
Review Comment:
Should we add a `InterfaceAudience.Private` here? We can start adding `InterfaceAudience` and `InterfaceStability` to these classes to clarify the interface contracts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16193. Clean up ScmClient [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on code in PR #11035:
URL: https://github.com/apache/ozone/pull/11035#discussion_r3800218494
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java:
##########
@@ -55,13 +54,6 @@
*/
@InterfaceStability.Unstable
Review Comment:
Should we add a `InterfaceAudience.Private` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16193. Clean up ScmClient [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #11035:
URL: https://github.com/apache/ozone/pull/11035#issuecomment-5336316057
Thanks @echonesis for the patch and @szetszwo for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16193. Clean up ScmClient [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on code in PR #11035:
URL: https://github.com/apache/ozone/pull/11035#discussion_r3800218494
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java:
##########
@@ -55,13 +54,6 @@
*/
@InterfaceStability.Unstable
Review Comment:
Should we add a `InterfaceAudience.Private` here? We can start adding `InterfaceAudience` and `InterfaceStability` to these classes to clarify the interface contracts. @szetszwo what do you think?
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java:
##########
@@ -55,13 +54,6 @@
*/
@InterfaceStability.Unstable
Review Comment:
Should we add a `InterfaceAudience.Private` here? We can start adding `InterfaceAudience` and `InterfaceStability` to these classes to clarify the interface contracts. @szetszwo @echonesis what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16193. Clean up ScmClient [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 merged PR #11035:
URL: https://github.com/apache/ozone/pull/11035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org