You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/06/30 08:04:41 UTC
[GitHub] [druid] clintropolis opened a new pull request, #12720: add virtual column support to search query
clintropolis opened a new pull request, #12720:
URL: https://github.com/apache/druid/pull/12720
### Description
This PR adds `virtualColumns` to the Druid native "search" query type, allowing searching values within dimension on top of them.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #12720: add virtual column support to search query
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on PR #12720:
URL: https://github.com/apache/druid/pull/12720#issuecomment-1174625759
@clintropolis - could you leave some comments for the release notes? I think this change is worth highlighting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #12720: add virtual column support to search query
Posted by GitBox <gi...@apache.org>.
clintropolis merged PR #12720:
URL: https://github.com/apache/druid/pull/12720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #12720: add virtual column support to search query
Posted by GitBox <gi...@apache.org>.
clintropolis commented on PR #12720:
URL: https://github.com/apache/druid/pull/12720#issuecomment-1175713656
> @clintropolis - could you leave some comments for the release notes? I think this change is worth highlighting.
Ah yeah, I think the docs need updated too, was going to do that as a follow-up. I'll think about what the release notes blurb should be and get back to this. The main reason I've added this is actually to support native search queries for #12695 so need to think a bit on the best way to frame this, since i'm not sure how useful this functionality would be for normal expression virtual columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org