Re: [jira] Updated: (DERBY-1758) Enable xmlSuite to run as part of derbyall for JVMs that embed the required external jars.

[Bryan Pendleton <bp...@amberpoint.com>]

> A B updated DERBY-1758:
> -----------------------
> 
> Attaching a "phase 1" patch that adds two JUnit tests to lang/_Suite.java.

Hi Army,

Jira email seems to be down, as Jean noted, so I'm just mailing the list
to indicate that I've started to look at your patch. I see in the Jira entry
that you've already updated it to patch version 2 so that's the one I'm
looking at.

thanks,

bryan

Re: [jira] Updated: (DERBY-1758) Enable xmlSuite to run as part of derbyall for JVMs that embed the required external jars.

[Bryan Pendleton <bp...@amberpoint.com>]

> noticed that you wrote "basically" here and that you said "in general" 
> in your comments for the Jira.  Is there anything in particular about 
> the patch that is prompting these qualifiers?  

No, there isn't. I'm not sure why I was weaseling; I think I was just tired. :)

I intend to commit the v2 patch this weekend.

thanks,

bryan

Re: [jira] Updated: (DERBY-1758) Enable xmlSuite to run as part of derbyall for JVMs that embed the required external jars.

[Army <qo...@gmail.com>]

Bryan Pendleton wrote:

> Hi Army,
> 
> I put a few notes into the Jira issue, but basically I didn't
> encounter any problems with your second patch.

Thank you for reviewing the patch, Bryan, and for the comments.  I noticed that 
you wrote "basically" here and that you said "in general" in your comments for 
the Jira.  Is there anything in particular about the patch that is prompting 
these qualifiers?  Feel free to let me know if there's something you'd like to 
see changed--I'm open to making the patch better where possible.

> Is this patch ready for commit? If so, I'll go ahead and commit it.

I haven't heard anything from anyone else about the patch, and so far as I know 
no one else is reviewing it.  So yes, I think this patch is ready for commit 
(thanks for offering!).

Note that if you do have some suggestions about how to make the patch better, we 
could still commit the current (_v2) patch and then I can post a follow-up to 
address your suggestions (similar to what was done for DERBY-1976).

Thanks, as always, for being so willing to review and commit.  I appreciate it!

Army

Re: [jira] Updated: (DERBY-1758) Enable xmlSuite to run as part of derbyall for JVMs that embed the required external jars.

[Bryan Pendleton <bp...@amberpoint.com>]

Hi Army,

I put a few notes into the Jira issue, but basically I didn't
encounter any problems with your second patch.

Is this patch ready for commit? If so, I'll go ahead and commit it.

thanks,

bryan

Re: [jira] Updated: (DERBY-1758) Enable xmlSuite to run as part of derbyall for JVMs that embed the required external jars.

[Army <qo...@gmail.com>]

Bryan Pendleton wrote:
> 
> Jira email seems to be down, as Jean noted, so I'm just mailing the list
> to indicate that I've started to look at your patch. I see in the Jira 
> entry that you've already updated it to patch version 2 so that's the one
> I'm looking at.

Great, thanks Bryan!

Army