You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/10 22:59:00 UTC
[GitHub] [phoenix] tkhurana opened a new pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
tkhurana opened a new pull request #961:
URL: https://github.com/apache/phoenix/pull/961
MutationState.join() ignores index rows in row count so totalRowCount calculated
will reflect the data table always and the index table only if the bestPlan
uses the index table. So ignore the other index tables when determining
the number of tables updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725944480
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 44s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 12m 27s | 4.x passed |
| +1 :green_heart: | compile | 1m 16s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 44s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 56s | 4.x passed |
| +0 :ok: | spotbugs | 4m 12s | phoenix-core in 4.x has 946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 2s | the patch passed |
| +1 :green_heart: | compile | 1m 12s | the patch passed |
| +1 :green_heart: | javac | 1m 12s | the patch passed |
| -1 :x: | checkstyle | 0m 43s | phoenix-core: The patch generated 11 new + 355 unchanged - 13 fixed = 366 total (was 368) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 1m 0s | the patch passed |
| +1 :green_heart: | spotbugs | 4m 17s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 203m 14s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. |
| | | 243m 14s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.index.PartialIndexRebuilderIT |
| | phoenix.end2end.index.GlobalIndexOptimizationIT |
| | phoenix.schema.stats.NoOpStatsCollectorIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/961 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 83fd0bb0a25d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 565b0ea |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/3/testReport/ |
| Max. process+thread count | 5987 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/3/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #961:
URL: https://github.com/apache/phoenix/pull/961#discussion_r522483197
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
##########
@@ -899,6 +899,39 @@ public void testUpdateNonIndexedColumn() throws Exception {
}
}
+ @Test
+ public void testDeleteCount_nonPK() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
Review comment:
is there a reason we need this test carried over from the immutable index test but not the others?
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java
##########
@@ -630,4 +632,181 @@ public Thread newThread(Runnable r) {
}
}
+ @Test
+ public void testDeleteCount_PK() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
+ String dataTableFullName = SchemaUtil.getTableName(schemaName, dataTableName);
+ String indexTableName = "IND_" + generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+
+ conn.createStatement().execute("CREATE TABLE " + dataTableFullName
+ + " (ID INTEGER NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER) "
+ + this.tableDDLOptions);
+
+ conn.createStatement().execute(String.format(
+ "CREATE INDEX %s ON %s (VAL1) INCLUDE (VAL2)", indexTableName, dataTableFullName));
+
+ PreparedStatement dataPreparedStatement =
+ conn.prepareStatement("UPSERT INTO " + dataTableFullName + " VALUES(?,?,?)");
+ for (int i = 1; i <= 10; i++) {
+ dataPreparedStatement.setInt(1, i);
+ dataPreparedStatement.setInt(2, i + 1);
+ dataPreparedStatement.setInt(3, i * 2);
+ dataPreparedStatement.execute();
+ }
+ conn.commit();
+
+ PreparedStatement deleteStmt =
+ conn.prepareStatement("DELETE FROM " + dataTableFullName + " WHERE ID > 5");
+ assertEquals(5, deleteStmt.executeUpdate());
+ conn.commit();
+ }
+ }
+
+ @Test
+ public void testDeleteCount_nonPK() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
+ String dataTableFullName = SchemaUtil.getTableName(schemaName, dataTableName);
+ String indexTableName = "IND_" + generateUniqueName();
+ String indexTableName2 = "IND_" + generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+
+ conn.createStatement().execute("CREATE TABLE " + dataTableFullName
+ + " (ID INTEGER NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER) "
+ + this.tableDDLOptions);
+
+ conn.createStatement().execute(String.format(
+ "CREATE INDEX %s ON %s (VAL1) INCLUDE (VAL2)", indexTableName, dataTableFullName));
+
+ conn.createStatement().execute(String.format(
+ "CREATE INDEX %s ON %s (VAL2) INCLUDE (VAL1)", indexTableName2, dataTableFullName));
+
+ PreparedStatement dataPreparedStatement =
+ conn.prepareStatement("UPSERT INTO " + dataTableFullName + " VALUES(?,?,?)");
+ for (int i = 1; i <= 10; i++) {
+ dataPreparedStatement.setInt(1, i);
+ dataPreparedStatement.setInt(2, i + 1);
+ dataPreparedStatement.setInt(3, i * 2);
+ dataPreparedStatement.execute();
+ }
+ conn.commit();
+
+ PreparedStatement deleteStmt =
+ conn.prepareStatement("DELETE FROM " + dataTableFullName + " WHERE VAL1 > 6");
+ assertEquals(5, deleteStmt.executeUpdate());
+ conn.commit();
+ }
+ }
+
+ @Test
+ public void testDeleteCount_limit() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
+ String dataTableFullName = SchemaUtil.getTableName(schemaName, dataTableName);
+ String indexTableName = "IND_" + generateUniqueName();
+ String indexTableName2 = "IND_" + generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+
+ conn.createStatement().execute("CREATE TABLE " + dataTableFullName
+ + " (ID INTEGER NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER) "
+ + this.tableDDLOptions);
+
+ conn.createStatement().execute(String.format(
+ "CREATE INDEX %s ON %s (VAL1) INCLUDE (VAL2)", indexTableName, dataTableFullName));
+
+ conn.createStatement().execute(String.format(
+ "CREATE INDEX %s ON %s (VAL2) INCLUDE (VAL1)", indexTableName2, dataTableFullName));
+
+ PreparedStatement dataPreparedStatement =
+ conn.prepareStatement("UPSERT INTO " + dataTableFullName + " VALUES(?,?,?)");
+ for (int i = 1; i <= 10; i++) {
+ dataPreparedStatement.setInt(1, i);
+ dataPreparedStatement.setInt(2, i + 1);
+ dataPreparedStatement.setInt(3, i * 2);
+ dataPreparedStatement.execute();
+ }
+ conn.commit();
+
+ PreparedStatement deleteStmt =
+ conn.prepareStatement("DELETE FROM " + dataTableFullName + " WHERE VAL1 > 6 LIMIT 3");
+ assertEquals(3, deleteStmt.executeUpdate());
+ conn.commit();
+ }
+ }
+
+ @Test
+ public void testDeleteCount_noCoveredColumn() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
+ String dataTableFullName = SchemaUtil.getTableName(schemaName, dataTableName);
+ String indexTableName = "IND_" + generateUniqueName();
+ String indexTableName2 = "IND_" + generateUniqueName();
Review comment:
Setup code looks copy-pasted multiple times; could you please extract to a helper method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana closed pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana closed pull request #961:
URL: https://github.com/apache/phoenix/pull/961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-726580889
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 10s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 52s | 4.x passed |
| +1 :green_heart: | compile | 1m 0s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 36s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 45s | 4.x passed |
| +0 :ok: | spotbugs | 3m 10s | phoenix-core in 4.x has 946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 7s | the patch passed |
| +1 :green_heart: | compile | 0m 57s | the patch passed |
| +1 :green_heart: | javac | 0m 57s | the patch passed |
| -1 :x: | checkstyle | 0m 36s | phoenix-core: The patch generated 9 new + 357 unchanged - 11 fixed = 366 total (was 368) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 20s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 179m 43s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. |
| | | 213m 13s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.index.PartialIndexRebuilderIT |
| | phoenix.end2end.UpsertSelectIT |
| | phoenix.end2end.IndexBuildTimestampIT |
| | phoenix.end2end.AlterTableIT |
| | phoenix.end2end.DropIndexedColsIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/961 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux e7b363394f40 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 565b0ea |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/5/testReport/ |
| Max. process+thread count | 6089 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/5/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 merged pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
gjacoby126 merged pull request #961:
URL: https://github.com/apache/phoenix/pull/961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] dbwong commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
dbwong commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725028120
Another question, I see the JIRA does not make a difference between sever and client side deletions. Did we test both paths? I'm assuming the new ITs hit the client path but I don't see any assertion of that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725056498
> Another question, I see the JIRA does not make a difference between sever and client side deletions. Did we test both paths? I'm assuming the new ITs hit the client path but I don't see any assertion of that.
The bug is only for client side deletes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on a change in pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on a change in pull request #961:
URL: https://github.com/apache/phoenix/pull/961#discussion_r522497471
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
##########
@@ -899,6 +899,39 @@ public void testUpdateNonIndexedColumn() throws Exception {
}
}
+ @Test
+ public void testDeleteCount_nonPK() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
Review comment:
I just wanted to make sure I didn't break anything for mutable indexes so added a test to verify. The bug only applies to immutable index but the code is shared between both immutable and mutable. I could carry all the tests. What do you suggest ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-726496100
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 9s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 35s | 4.x passed |
| +1 :green_heart: | compile | 0m 57s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 36s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 48s | 4.x passed |
| +0 :ok: | spotbugs | 3m 9s | phoenix-core in 4.x has 946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 20s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| -1 :x: | checkstyle | 0m 37s | phoenix-core: The patch generated 11 new + 355 unchanged - 13 fixed = 366 total (was 368) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 22s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 175m 30s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. |
| | | 208m 50s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/961 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 89cb2ba60dec 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 565b0ea |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/4/testReport/ |
| Max. process+thread count | 6186 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/4/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-726979083
> @tkhurana - 4 of the 5 test failures are just timeouts, but could you please verify that UpsertSelectIT passes locally for you? That failure's coming from a failed assertion. Thanks!
@gjacoby126 Yes, it is passing locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana edited a comment on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana edited a comment on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725062521
> A few questions for this.
>
> * This is only on the client side delete path changes, this seemed to be trying to handle projected tables but I don't see any test cases with such projections.
> * ClientSelectDeleteMutationPlan has some special case handling for transactional tables, local indexes, and immutable tables. I didn't see test cases with transactional cases and local indexes.
The tests for immutable tables is parameterized on transactions and local indexes. In the new tests that I added I have skipped the transactions but I can remove that check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-726960446
@tkhurana - 4 of the 5 test failures are just timeouts, but could you please verify that UpsertSelectIT passes locally for you? That failure's coming from a failed assertion. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on a change in pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on a change in pull request #961:
URL: https://github.com/apache/phoenix/pull/961#discussion_r522505502
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
##########
@@ -899,6 +899,39 @@ public void testUpdateNonIndexedColumn() throws Exception {
}
}
+ @Test
+ public void testDeleteCount_nonPK() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
Review comment:
Sounds good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725086396
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 41s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 12m 29s | 4.x passed |
| +1 :green_heart: | compile | 1m 1s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 36s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.x passed |
| +0 :ok: | spotbugs | 3m 10s | phoenix-core in 4.x has 946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 15s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| -1 :x: | checkstyle | 0m 38s | phoenix-core: The patch generated 4 new + 364 unchanged - 4 fixed = 368 total (was 368) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 19s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 170m 6s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. |
| | | 204m 48s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.IndexExtendedIT |
| | phoenix.end2end.UpgradeIT |
| | phoenix.end2end.OrderByWithSpillingIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/961 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux c2429db1b997 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 21e729f |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/1/testReport/ |
| Max. process+thread count | 6024 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana edited a comment on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana edited a comment on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725056498
> Another question, I see the JIRA does not make a difference between sever and client side deletions. Did we test both paths? I'm assuming the new ITs hit the client path but I don't see any assertion of that.
The bug is only for client side deletes. I updated the jira title to reflect that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725046589
> Another question, I see the JIRA does not make a difference between sever and client side deletions. Did we test both paths? I'm assuming the new ITs hit the client path but I don't see any assertion of that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on a change in pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on a change in pull request #961:
URL: https://github.com/apache/phoenix/pull/961#discussion_r522497471
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
##########
@@ -899,6 +899,39 @@ public void testUpdateNonIndexedColumn() throws Exception {
}
}
+ @Test
+ public void testDeleteCount_nonPK() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
Review comment:
I just wanted to make sure I didn't break anything for mutable indexes so added a test to verify. The bug only applies to immutable index but the code is shared between both immutable and mutable. I could carry all the tests. What do you suggest ? @gjacoby126
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] dbwong commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
dbwong commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725035898
Last questions what is the impact to changing the output of MutationState::getUpdateCount() in the paths where that is used? Its not clear to me, I tried to follow the change but only went to the writing of the tuple in one of the iterators...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725062521
> A few questions for this.
>
> * This is only on the client side delete path changes, this seemed to be trying to handle projected tables but I don't see any test cases with such projections.
> * ClientSelectDeleteMutationPlan has some special case handling for transactional tables, local indexes, and immutable tables. I didn't see test cases with transactional cases and local indexes.
The tests for immutable tables is parameterized on transactions and local indexes. In the new tests that I added I have skipped the transactions but I cam remove that check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] dbwong commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
dbwong commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725026641
A few questions for this.
- This is only on the client side delete path changes, this seemed to be trying to handle projected tables but I don't see any test cases with such projections.
- ClientSelectDeleteMutationPlan has some special case handling for transactional tables, local indexes, and immutable tables. I didn't see test cases with transactional cases and local indexes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-726982386
@tkhurana - I merged into 4.x, could you please also make a version for master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725018621
@kadirozde @dbwong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on a change in pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on a change in pull request #961:
URL: https://github.com/apache/phoenix/pull/961#discussion_r522486312
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java
##########
@@ -630,4 +632,181 @@ public Thread newThread(Runnable r) {
}
}
+ @Test
+ public void testDeleteCount_PK() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
+ String dataTableFullName = SchemaUtil.getTableName(schemaName, dataTableName);
+ String indexTableName = "IND_" + generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+
+ conn.createStatement().execute("CREATE TABLE " + dataTableFullName
+ + " (ID INTEGER NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER) "
+ + this.tableDDLOptions);
+
+ conn.createStatement().execute(String.format(
+ "CREATE INDEX %s ON %s (VAL1) INCLUDE (VAL2)", indexTableName, dataTableFullName));
+
+ PreparedStatement dataPreparedStatement =
+ conn.prepareStatement("UPSERT INTO " + dataTableFullName + " VALUES(?,?,?)");
+ for (int i = 1; i <= 10; i++) {
+ dataPreparedStatement.setInt(1, i);
+ dataPreparedStatement.setInt(2, i + 1);
+ dataPreparedStatement.setInt(3, i * 2);
+ dataPreparedStatement.execute();
+ }
+ conn.commit();
+
+ PreparedStatement deleteStmt =
+ conn.prepareStatement("DELETE FROM " + dataTableFullName + " WHERE ID > 5");
+ assertEquals(5, deleteStmt.executeUpdate());
+ conn.commit();
+ }
+ }
+
+ @Test
+ public void testDeleteCount_nonPK() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
+ String dataTableFullName = SchemaUtil.getTableName(schemaName, dataTableName);
+ String indexTableName = "IND_" + generateUniqueName();
+ String indexTableName2 = "IND_" + generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+
+ conn.createStatement().execute("CREATE TABLE " + dataTableFullName
+ + " (ID INTEGER NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER) "
+ + this.tableDDLOptions);
+
+ conn.createStatement().execute(String.format(
+ "CREATE INDEX %s ON %s (VAL1) INCLUDE (VAL2)", indexTableName, dataTableFullName));
+
+ conn.createStatement().execute(String.format(
+ "CREATE INDEX %s ON %s (VAL2) INCLUDE (VAL1)", indexTableName2, dataTableFullName));
+
+ PreparedStatement dataPreparedStatement =
+ conn.prepareStatement("UPSERT INTO " + dataTableFullName + " VALUES(?,?,?)");
+ for (int i = 1; i <= 10; i++) {
+ dataPreparedStatement.setInt(1, i);
+ dataPreparedStatement.setInt(2, i + 1);
+ dataPreparedStatement.setInt(3, i * 2);
+ dataPreparedStatement.execute();
+ }
+ conn.commit();
+
+ PreparedStatement deleteStmt =
+ conn.prepareStatement("DELETE FROM " + dataTableFullName + " WHERE VAL1 > 6");
+ assertEquals(5, deleteStmt.executeUpdate());
+ conn.commit();
+ }
+ }
+
+ @Test
+ public void testDeleteCount_limit() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
+ String dataTableFullName = SchemaUtil.getTableName(schemaName, dataTableName);
+ String indexTableName = "IND_" + generateUniqueName();
+ String indexTableName2 = "IND_" + generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+
+ conn.createStatement().execute("CREATE TABLE " + dataTableFullName
+ + " (ID INTEGER NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER) "
+ + this.tableDDLOptions);
+
+ conn.createStatement().execute(String.format(
+ "CREATE INDEX %s ON %s (VAL1) INCLUDE (VAL2)", indexTableName, dataTableFullName));
+
+ conn.createStatement().execute(String.format(
+ "CREATE INDEX %s ON %s (VAL2) INCLUDE (VAL1)", indexTableName2, dataTableFullName));
+
+ PreparedStatement dataPreparedStatement =
+ conn.prepareStatement("UPSERT INTO " + dataTableFullName + " VALUES(?,?,?)");
+ for (int i = 1; i <= 10; i++) {
+ dataPreparedStatement.setInt(1, i);
+ dataPreparedStatement.setInt(2, i + 1);
+ dataPreparedStatement.setInt(3, i * 2);
+ dataPreparedStatement.execute();
+ }
+ conn.commit();
+
+ PreparedStatement deleteStmt =
+ conn.prepareStatement("DELETE FROM " + dataTableFullName + " WHERE VAL1 > 6 LIMIT 3");
+ assertEquals(3, deleteStmt.executeUpdate());
+ conn.commit();
+ }
+ }
+
+ @Test
+ public void testDeleteCount_noCoveredColumn() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
+ String dataTableFullName = SchemaUtil.getTableName(schemaName, dataTableName);
+ String indexTableName = "IND_" + generateUniqueName();
+ String indexTableName2 = "IND_" + generateUniqueName();
Review comment:
Sure, will do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #961:
URL: https://github.com/apache/phoenix/pull/961#discussion_r522501965
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
##########
@@ -899,6 +899,39 @@ public void testUpdateNonIndexedColumn() throws Exception {
}
}
+ @Test
+ public void testDeleteCount_nonPK() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
Review comment:
I'd lean toward carrying them all over. It seems like we had a testing gap around affected row counts and you've written a good set of tests to cover that gap for both kinds of table (even if we have no reason to think there's anything wrong with mutable tables).
With the right common helper methods it won't add much code and I don't expect it to lengthen test suite runtime much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana edited a comment on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana edited a comment on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725062521
> A few questions for this.
>
> * This is only on the client side delete path changes, this seemed to be trying to handle projected tables but I don't see any test cases with such projections.
> * ClientSelectDeleteMutationPlan has some special case handling for transactional tables, local indexes, and immutable tables. I didn't see test cases with transactional cases and local indexes.
The tests for immutable tables is parameterized on transactions and local indexes. In the new tests that I added I have skipped the transactions but I can remove that check.
@dbwong I didn't understand what you meant by handling projected tables. Can you please elaborate ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana removed a comment on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana removed a comment on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725046589
> Another question, I see the JIRA does not make a difference between sever and client side deletions. Did we test both paths? I'm assuming the new ITs hit the client path but I don't see any assertion of that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725061732
> Last questions what is the impact to changing the output of MutationState::getUpdateCount() in the paths where that is used? Its not clear to me, I tried to follow the change but only went to the writing of the tuple in one of the iterators...
@dbwong are you suggesting to change MutationState to report row count for all updated tables ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #961: PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725248399
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 44s | 4.x passed |
| +1 :green_heart: | compile | 1m 0s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 37s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.x passed |
| +0 :ok: | spotbugs | 3m 7s | phoenix-core in 4.x has 946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 17s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| -1 :x: | checkstyle | 0m 37s | phoenix-core: The patch generated 2 new + 366 unchanged - 2 fixed = 368 total (was 368) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 21s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 247m 15s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 58s | The patch does not generate ASF License warnings. |
| | | 282m 4s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.index.PartialIndexRebuilderIT |
| | phoenix.end2end.IntArithmeticIT |
| | phoenix.end2end.IndexBuildTimestampIT |
| | phoenix.end2end.ViewMetadataIT |
| | TEST-[RangeScanIT_2] |
| | phoenix.end2end.RowValueConstructorOffsetIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/961 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 2afc6cede537 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 21e729f |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/2/testReport/ |
| Max. process+thread count | 6177 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org