You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2016/02/02 12:25:51 UTC
Review Request 43087: AMBARI-14875 : Ranger Smart configs : Need to
hide Audit DB properties if Audit to DB is off
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43087/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: AMBARI-14875
https://issues.apache.org/jira/browse/AMBARI-14875
Repository: ambari
Description
-------
Earlier, Audit to DB related config properties use to be visible for Ranger Admin (during installation) as those were mandatory set of properties to install Ranger Admin. As Ranger Admin is now moving away from default Audit to DB settings, same changes are needed in Ambari stacks as well.
Attached patch has changes in theme_version_2.json to hide Ranger's Audit to DB related configuration properties if Audit to DB is disabled.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json fff50fb
Diff: https://reviews.apache.org/r/43087/diff/
Testing
-------
Installed Ranger and verified toggling of 'Audit to DB flag' hides Audit to DB related configuration properties.
Thanks,
Gautam Borad
Re: Review Request 43087: AMBARI-14875 : Ranger Smart configs : Need
to hide Audit DB properties if Audit to DB is off
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43087/#review118378
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Фев. 9, 2016, 9:40 д.п., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43087/
> -----------------------------------------------------------
>
> (Updated Фев. 9, 2016, 9:40 д.п.)
>
>
> Review request for Ambari, Andriy Babiichuk, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14875
> https://issues.apache.org/jira/browse/AMBARI-14875
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Earlier, Audit to DB related config properties used to be visible for Ranger Admin (during installation) as those were mandatory set of properties to install Ranger Admin. As Ranger Admin is now moving away from default Audit to DB settings, changes are needed in Ambari stacks as well.
>
> Attached patch has changes in theme_version_2.json to hide Ranger's Audit to DB related configuration properties if Audit to DB is disabled.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/themes/theme_version_1.json cb5aa78
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json 2c469a9
>
> Diff: https://reviews.apache.org/r/43087/diff/
>
>
> Testing
> -------
>
> Installed Ranger and verified toggling of 'Audit to DB flag' hides Audit to DB related configuration properties.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 43087: AMBARI-14875 : Ranger Smart configs : Need
to hide Audit DB properties if Audit to DB is off
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43087/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 9:40 a.m.)
Review request for Ambari, Andriy Babiichuk, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Patch needs to be updated, as it has changes in same line of code as in AMBARI-14933
Bugs: AMBARI-14875
https://issues.apache.org/jira/browse/AMBARI-14875
Repository: ambari
Description (updated)
-------
Earlier, Audit to DB related config properties used to be visible for Ranger Admin (during installation) as those were mandatory set of properties to install Ranger Admin. As Ranger Admin is now moving away from default Audit to DB settings, changes are needed in Ambari stacks as well.
Attached patch has changes in theme_version_2.json to hide Ranger's Audit to DB related configuration properties if Audit to DB is disabled.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/themes/theme_version_1.json cb5aa78
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json 2c469a9
Diff: https://reviews.apache.org/r/43087/diff/
Testing
-------
Installed Ranger and verified toggling of 'Audit to DB flag' hides Audit to DB related configuration properties.
Thanks,
Gautam Borad