You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Jonathan Chang (Created) (JIRA)" <ji...@apache.org> on 2012/01/18 23:22:39 UTC
[jira] [Created] (HIVE-2726) COALESCE(NULL, NULL) NPEs
COALESCE(NULL, NULL) NPEs
-------------------------
Key: HIVE-2726
URL: https://issues.apache.org/jira/browse/HIVE-2726
Project: Hive
Issue Type: Bug
Reporter: Jonathan Chang
Priority: Minor
ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2726) COALESCE(NULL, NULL) NPEs
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2726:
------------------------------
Attachment: HIVE-2726.D1317.1.patch
jonchang requested code review of "HIVE-2726 [jira] COALESCE(NULL, NULL) NPEs".
Reviewers: JIRA
HIVE-2726
ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1317
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java
ql/src/test/queries/clientpositive/udf_coalesce.q
ql/src/test/results/clientpositive/udf_coalesce.q.out
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2745/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> COALESCE(NULL, NULL) NPEs
> -------------------------
>
> Key: HIVE-2726
> URL: https://issues.apache.org/jira/browse/HIVE-2726
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Priority: Minor
> Attachments: HIVE-2726.D1317.1.patch
>
>
> ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2726) COALESCE(NULL, NULL) NPEs
Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2726:
-----------------------------
Status: Open (was: Patch Available)
> COALESCE(NULL, NULL) NPEs
> -------------------------
>
> Key: HIVE-2726
> URL: https://issues.apache.org/jira/browse/HIVE-2726
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Priority: Minor
> Attachments: HIVE-2726.D1317.1.patch, HIVE-2726.D1317.1.patch
>
>
> ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2726) COALESCE(NULL, NULL) NPEs
Posted by "Jonathan Chang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Chang updated HIVE-2726:
---------------------------------
Attachment: HIVE-2726.D1317.1.patch
> COALESCE(NULL, NULL) NPEs
> -------------------------
>
> Key: HIVE-2726
> URL: https://issues.apache.org/jira/browse/HIVE-2726
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Priority: Minor
> Attachments: HIVE-2726.D1317.1.patch, HIVE-2726.D1317.1.patch
>
>
> ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2726) COALESCE(NULL, NULL) NPEs
Posted by "Namit Jain (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203850#comment-13203850 ]
Namit Jain commented on HIVE-2726:
----------------------------------
The following tests failed:
udaf_context_ngrams.q
udf_array.q
udf_map.q
udf_sort_array.q
Can you take a look ?
For udf_array and udf_map, the output needs to be updated. I haven't looked at the other 2.
> COALESCE(NULL, NULL) NPEs
> -------------------------
>
> Key: HIVE-2726
> URL: https://issues.apache.org/jira/browse/HIVE-2726
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Priority: Minor
> Attachments: HIVE-2726.D1317.1.patch, HIVE-2726.D1317.1.patch
>
>
> ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2726) COALESCE(NULL, NULL) NPEs
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2726:
------------------------------
Attachment: HIVE-2726.D1317.2.patch
jonchang updated the revision "HIVE-2726 [jira] COALESCE(NULL, NULL) NPEs".
Reviewers: JIRA, jsichi, raghotham, njain
Change the way it works so it no loner applies to ARRAY() and MAP(). Also clean up the way SORT_ARRAY() works.
REVISION DETAIL
https://reviews.facebook.net/D1317
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java
ql/src/test/queries/clientpositive/udf_coalesce.q
ql/src/test/results/clientpositive/udf_coalesce.q.out
ql/src/test/results/clientpositive/udf_sort_array.q.out
> COALESCE(NULL, NULL) NPEs
> -------------------------
>
> Key: HIVE-2726
> URL: https://issues.apache.org/jira/browse/HIVE-2726
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Priority: Minor
> Attachments: HIVE-2726.D1317.1.patch, HIVE-2726.D1317.1.patch, HIVE-2726.D1317.2.patch, HIVE-2726.D1677.1.patch
>
>
> ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2726) COALESCE(NULL, NULL) NPEs
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2726:
------------------------------
Attachment: HIVE-2726.D1677.1.patch
jonchang requested code review of "HIVE-2726 [jira] COALESCE(NULL, NULL) NPEs".
Reviewers: JIRA
HIVE-2726
ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1677
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java
ql/src/test/queries/clientpositive/udf_coalesce.q
ql/src/test/results/clientpositive/udf_coalesce.q.out
ql/src/test/results/clientpositive/udf_sort_array.q.out
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3567/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> COALESCE(NULL, NULL) NPEs
> -------------------------
>
> Key: HIVE-2726
> URL: https://issues.apache.org/jira/browse/HIVE-2726
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Priority: Minor
> Attachments: HIVE-2726.D1317.1.patch, HIVE-2726.D1317.1.patch, HIVE-2726.D1677.1.patch
>
>
> ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2726) COALESCE(NULL, NULL) NPEs
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203165#comment-13203165 ]
Phabricator commented on HIVE-2726:
-----------------------------------
njain has accepted the revision "HIVE-2726 [jira] COALESCE(NULL, NULL) NPEs".
running tests
REVISION DETAIL
https://reviews.facebook.net/D1317
> COALESCE(NULL, NULL) NPEs
> -------------------------
>
> Key: HIVE-2726
> URL: https://issues.apache.org/jira/browse/HIVE-2726
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Priority: Minor
> Attachments: HIVE-2726.D1317.1.patch
>
>
> ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2726) COALESCE(NULL, NULL) NPEs
Posted by "Jonathan Chang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Chang updated HIVE-2726:
---------------------------------
Assignee: Jonathan Chang
Status: Patch Available (was: Open)
> COALESCE(NULL, NULL) NPEs
> -------------------------
>
> Key: HIVE-2726
> URL: https://issues.apache.org/jira/browse/HIVE-2726
> Project: Hive
> Issue Type: Bug
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Priority: Minor
> Attachments: HIVE-2726.D1317.1.patch
>
>
> ReturnOIResolver returns null when it gets no non-void arguments. This is bad.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira