[jira] [Commented] (MYFACES-3791) [perf] reuse _SelectItemsIterator in UISelectOne.validateValue

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798197#comment-13798197 ] 

Leonardo Uribe commented on MYFACES-3791:
-----------------------------------------

It seems in MYFACES-3710 we did something different to reuse _SelectItemsIterator, just creating a simple array that hold the values. 

1) I think it could happen in UISelectMany.
2) There is a hard copy so any changes in _SelectItemsIterator should be done in shared SelectItemsIterator

I think the solution applied in MYFACES-3710 is better, so I'll close this one as duplicate. Thanks anyway for the patch. 

> [perf] reuse _SelectItemsIterator in UISelectOne.validateValue
> --------------------------------------------------------------
>
>                 Key: MYFACES-3791
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3791
>             Project: MyFaces Core
>          Issue Type: Improvement
>         Environment: myfaces core trunk
>            Reporter: Martin Kočí
>            Priority: Minor
>         Attachments: MYFACES-3791-v1.patch
>
>
> Current  implementation of UISelectOne.validateValue creates (when component.requred = true) two instances of _SelectItemsIterator, iterates  2x  and evaluates ValueExpression for SelectItem(s) 2x.
> We can create one instance of SelectItemsIterator and store the noSelectionOption direct in the _SelectItemsIterator instance and reuse in noSelectionOption-block.
> Similar issue MYFACES-3710.



--
This message was sent by Atlassian JIRA
(v6.1#6144)