[jira] [Commented] (HBASE-3852) ThriftServer leaks scanners

["Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205805#comment-13205805 ] 

Zhihong Yu commented on HBASE-3852:
-----------------------------------

{code}
+      timestamp = System.currentTimeMillis();
{code}
We have EnvironmentEdgeManager which provides the above service.
{code}
+      for (Integer key: toremove)
+        removeScanner(key);
{code}
Please use curly braces around the removeScanner() call.
                
> ThriftServer leaks scanners
> ---------------------------
>
>                 Key: HBASE-3852
>                 URL: https://issues.apache.org/jira/browse/HBASE-3852
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.2
>            Reporter: Jean-Daniel Cryans
>            Priority: Critical
>             Fix For: 0.94.0
>
>         Attachments: 3852.txt, thrift2-scanner.patch
>
>
> The scannerMap in ThriftServer relies on the user to clean it by closing the scanner. If that doesn't happen, the ResultScanner will stay in the thrift server's memory and if any pre-fetching was done, it will also start accumulating Results (with all their data).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira