You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/07 10:36:34 UTC
[GitHub] [camel-website] zregvart commented on a change in pull request
#327: Search-Cancel Button position fixes in the search box
zregvart commented on a change in pull request #327: Search-Cancel Button position fixes in the search box
URL: https://github.com/apache/camel-website/pull/327#discussion_r404708121
##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -417,7 +417,7 @@ body {
#search-cancel {
position: relative;
bottom: 1.4rem;
- left: 10.6rem;
+ left: 7.5rem;
height: 1.1rem;
Review comment:
Perhaps instead of relying on specific numbers we can rely on the principles, this way if we change the search input field size the clear icon will be positioned correctly.
```suggestion
bottom: calc(50% - 0.15rem);
left: calc(100% - 1.25rem);
height: 1rem;
```
Not sure if 0.15 and 1.15 could be derived from a variable, that would be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services