You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zjureel <gi...@git.apache.org> on 2017/08/01 14:00:06 UTC
[GitHub] flink pull request #4455: [FLINK-7251] Merge the flink-java8 project into co...
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/4455
[FLINK-7251] Merge the flink-java8 project into corresponding flink project
## What is the purpose of the change
Merge the codes in flink-java8 project into corresponding flink project
## Brief change log
- *Merge examples into flink-examples project*
- *Merge runtime test into flink-runtime project*
- *Merge test case into flink-tests project*
- *Remove flink-java8 project*
## Verifying this change
*(Please pick either of the following options)*
This changes are examples and test cases without any test coverage
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
## Documentation
- Does this pull request introduce a new feature? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-7251
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4455.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4455
----
commit 39d0ed7a31f98d2d16beeaf0ff6418252933afc8
Author: zjureel <zj...@gmail.com>
Date: 2017-08-01T10:03:23Z
[FLINK-7251] mv examples to flink-examples
commit b11eb22793f2c28faa5765c817e83f7e79929e1b
Author: zjureel <zj...@gmail.com>
Date: 2017-08-01T10:08:06Z
[FLINK-7251] mv test case to flink-runtime
commit 544fbef0450155135ba52d5f4e9dde567ed3de80
Author: zjureel <zj...@gmail.com>
Date: 2017-08-01T10:11:57Z
[FLINK-7251] mv examples to flink-tests
commit 1f944726995b3173aaf24fd26a6a91b8f2d7f7e7
Author: zjureel <zj...@gmail.com>
Date: 2017-08-01T10:13:11Z
[FLINK-7251] mv test cases to flink-cep and flink-java
commit 645fa92fa4a5f3c9a6e0f49d77ebf9bbda6f5b01
Author: zjureel <zj...@gmail.com>
Date: 2017-08-01T10:14:10Z
[FLINK-7251] remove flink-java8 project
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zjureel <gi...@git.apache.org>.
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4455
@zentol Thank you for your suggestion, it sounds good to me and I have fixed them, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zjureel <gi...@git.apache.org>.
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4455
The `JobRetrievalITCase` is ok when I remove the tycho-compiler completely, I think it may be a bug of the tycho-compiler :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zjureel <gi...@git.apache.org>.
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4455
1. For the `StateBackendITCase`, it can be resolved by bumping the tycho compiler version to 1.0.0, but when I try to use tycho compiler version 1.0.0 in `flink-java`, it will cause lambda exception for `LambdaExtractionTest`. I think it's better to stay in the same version of tycho compiler in different flink project, so I try to modify the code of StateBackendITCase to resolve the problem directly.
2. For the `JobRetrievalITCase`, I try every version of tycho compiler, the problem always exists. I think tycho compiler may be incompatible with `Seq.last()` method. I try to use another method in `Seq` to get the last element in `JobRetrievalITCase`, and it would be ok
@zentol What do you think? Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4455
Could you check what happens when you remove the tycho-compiler completely?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zjureel <gi...@git.apache.org>.
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4455
@zentol Thank you for your reply, and I agree with you that the risk will be a little high for this PR. I'd like to close this PR if there's no better solution, thanks
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4455
We will have to revert every change that requires the tycho plugin to be moved into any other module. Using a different for these modules may have performance impacts and possibly subtle bugs.
Sorry that i didn't notice it earlier.
---
[GitHub] flink pull request #4455: [FLINK-7251] Merge the flink-java8 project into co...
Posted by zjureel <gi...@git.apache.org>.
Github user zjureel closed the pull request at:
https://github.com/apache/flink/pull/4455
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4455
Are you talking about things like `FlatMapITCase`? I would suggest to integrate these into the existing ITCase in `flink-tests`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4455
There's a compilation failure in flink-tests:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project flink-tests_2.11: Compilation failure: Compilation failure:
[ERROR] /home/travis/build/apache/flink/flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/StateBackendITCase.java:[67]
[ERROR] .map(new RichMapFunction<Tuple2<String, Integer>, String>() {
[ERROR] ^^^
[ERROR] The method map(MapFunction<Tuple2<String,Object>,R>) in the type DataStream<Tuple2<String,Object>> is not applicable for the arguments (new RichMapFunction<Tuple2<String,Integer>,String>(){})
[ERROR] /home/travis/build/apache/flink/flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java:[99]
[ERROR] final ActorSystem actorSystem = actorSystemSeq.last();
[ERROR] ^^^^
[ERROR] The method last() is ambiguous for the type Seq<ActorSystem>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zjureel <gi...@git.apache.org>.
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4455
Maybe it's better to move *ITCase to `Flink-java` project and rename them to *Test, I find it will be alright, what do you think? @zentol
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4455
This would be easier to review (and for git to keep track of) if the individual commits would actually move a file, and not just copy them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4455
The StateBackendITCase can be resolved by bumping the tycho compiler version to 1.0.0, but the scala one remains.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---