You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Edgar Poce (JIRA)" <ji...@apache.org> on 2005/08/16 15:37:17 UTC
[jira] Created: (JCR-188) Item states cached in UpdatableItemStateManager not discarded on logout
Item states cached in UpdatableItemStateManager not discarded on logout
-----------------------------------------------------------------------
Key: JCR-188
URL: http://issues.apache.org/jira/browse/JCR-188
Project: Jackrabbit
Type: Improvement
Components: core
Reporter: Edgar Poce
Priority: Minor
The SessionItemStateManager disposes only the TransientItemStateManager but not the UpdatableItemStateManager. The latter doesn't release the resources and the cached items keep listening the overlayed state events until the ReferenceMap do its magic. According to my tests in certain circumstances it slows down jackrabbit very much.
In the charts you can see the time it takes to jackrabbit to save each child node. The first test uses a single session and the second creates a new session for each added node.
The patch I attach makes both tests take the same time. Opinions?
05-08-16-one session.GIF
/ login
/ loop
/ add node
/ save
/ logout
05-08-16-one session per save.GIF
/ loop
/ login
/ add node
/ save
/ logout
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-188) Item states cached in UpdatableItemStateManager not discarded on logout
Posted by "Edgar Poce (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-188?page=all ]
Edgar Poce updated JCR-188:
---------------------------
Attachment: 05-08-16-one session.GIF
05-08-12-one session per save.GIF
> Item states cached in UpdatableItemStateManager not discarded on logout
> -----------------------------------------------------------------------
>
> Key: JCR-188
> URL: http://issues.apache.org/jira/browse/JCR-188
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Reporter: Edgar Poce
> Assignee: Stefan Guggisberg
> Priority: Minor
> Attachments: 05-08-12-one session per save.GIF, 05-08-16-dispose.patch, 05-08-16-one session.GIF
>
> The SessionItemStateManager disposes only the TransientItemStateManager but not the UpdatableItemStateManager. The latter doesn't release the resources and the cached items keep listening the overlayed state events until the ReferenceMap do its magic. According to my tests in certain circumstances it slows down jackrabbit very much.
> In the charts you can see the time it takes to jackrabbit to save each child node. The first test uses a single session and the second creates a new session for each added node.
> The patch I attach makes both tests take the same time. Opinions?
> 05-08-16-one session.GIF
> / login
> / loop
> / add node
> / save
> / logout
> 05-08-16-one session per save.GIF
> / loop
> / login
> / add node
> / save
> / logout
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (JCR-188) Item states cached in UpdatableItemStateManager not discarded on logout
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-188?page=all ]
Stefan Guggisberg closed JCR-188:
---------------------------------
Fix Version: 1.0
Resolution: Fixed
fixed as suggested (r233459)
good job edgar, thanks!
> Item states cached in UpdatableItemStateManager not discarded on logout
> -----------------------------------------------------------------------
>
> Key: JCR-188
> URL: http://issues.apache.org/jira/browse/JCR-188
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Reporter: Edgar Poce
> Assignee: Stefan Guggisberg
> Priority: Minor
> Fix For: 1.0
> Attachments: 05-08-12-one session per save.GIF, 05-08-16-dispose.patch, 05-08-16-one session.GIF
>
> The SessionItemStateManager disposes only the TransientItemStateManager but not the UpdatableItemStateManager. The latter doesn't release the resources and the cached items keep listening the overlayed state events until the ReferenceMap do its magic. According to my tests in certain circumstances it slows down jackrabbit very much.
> In the charts you can see the time it takes to jackrabbit to save each child node. The first test uses a single session and the second creates a new session for each added node.
> The patch I attach makes both tests take the same time. Opinions?
> 05-08-16-one session.GIF
> / login
> / loop
> / add node
> / save
> / logout
> 05-08-16-one session per save.GIF
> / loop
> / login
> / add node
> / save
> / logout
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-188) Item states cached in UpdatableItemStateManager not discarded on logout
Posted by "Edgar Poce (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-188?page=all ]
Edgar Poce updated JCR-188:
---------------------------
Attachment: 05-08-16-dispose.patch
> Item states cached in UpdatableItemStateManager not discarded on logout
> -----------------------------------------------------------------------
>
> Key: JCR-188
> URL: http://issues.apache.org/jira/browse/JCR-188
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Reporter: Edgar Poce
> Assignee: Stefan Guggisberg
> Priority: Minor
> Attachments: 05-08-12-one session per save.GIF, 05-08-16-dispose.patch, 05-08-16-one session.GIF
>
> The SessionItemStateManager disposes only the TransientItemStateManager but not the UpdatableItemStateManager. The latter doesn't release the resources and the cached items keep listening the overlayed state events until the ReferenceMap do its magic. According to my tests in certain circumstances it slows down jackrabbit very much.
> In the charts you can see the time it takes to jackrabbit to save each child node. The first test uses a single session and the second creates a new session for each added node.
> The patch I attach makes both tests take the same time. Opinions?
> 05-08-16-one session.GIF
> / login
> / loop
> / add node
> / save
> / logout
> 05-08-16-one session per save.GIF
> / loop
> / login
> / add node
> / save
> / logout
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (JCR-188) Item states cached in UpdatableItemStateManager not discarded on logout
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-188?page=all ]
Stefan Guggisberg reassigned JCR-188:
-------------------------------------
Assign To: Stefan Guggisberg
> Item states cached in UpdatableItemStateManager not discarded on logout
> -----------------------------------------------------------------------
>
> Key: JCR-188
> URL: http://issues.apache.org/jira/browse/JCR-188
> Project: Jackrabbit
> Type: Improvement
> Components: core
> Reporter: Edgar Poce
> Assignee: Stefan Guggisberg
> Priority: Minor
>
> The SessionItemStateManager disposes only the TransientItemStateManager but not the UpdatableItemStateManager. The latter doesn't release the resources and the cached items keep listening the overlayed state events until the ReferenceMap do its magic. According to my tests in certain circumstances it slows down jackrabbit very much.
> In the charts you can see the time it takes to jackrabbit to save each child node. The first test uses a single session and the second creates a new session for each added node.
> The patch I attach makes both tests take the same time. Opinions?
> 05-08-16-one session.GIF
> / login
> / loop
> / add node
> / save
> / logout
> 05-08-16-one session per save.GIF
> / loop
> / login
> / add node
> / save
> / logout
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira