[GitHub] [arrow-rs] HaoYang670 edited a comment on issue #1400: Interesting benchmark results of `min_max_helper`

[GitBox <gi...@apache.org>]

HaoYang670 edited a comment on issue #1400:
URL: https://github.com/apache/arrow-rs/issues/1400#issuecomment-1059886865


   Also, using `copy` or `reference` seems to impact the performance of null handling loop. I get the following benchmark result:
   1. using `m.iter().copied().reduce(...)`:
   ```console
   min nulls 512           time:   [866.42 ns 867.35 ns 868.33 ns]                           
                           change: [-1.1100% -0.9494% -0.8086%] (p = 0.00 < 0.05)
                           Change within noise threshold.
   Found 9 outliers among 100 measurements (9.00%)
     7 (7.00%) high mild
     2 (2.00%) high severe
   ```
   3. using `m.iter().reduce(...).copied()`
   ```console
   
   min nulls 512           time:   [1.0525 us 1.0551 us 1.0576 us]                           
                           change: [+20.470% +20.793% +21.115%] (p = 0.00 < 0.05)
                           Performance has regressed.
   Found 2 outliers among 100 measurements (2.00%)
     2 (2.00%) high mild
   ```
   
   Is it able to reproduce these weird results on your laptop? @jhorstmann 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org