You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "perry2of5 (via GitHub)" <gi...@apache.org> on 2024/10/24 22:56:48 UTC
[PR] Add context to Azure Service Bus Message callback [airflow]
perry2of5 opened a new pull request, #43370:
URL: https://github.com/apache/airflow/pull/43370
The original callback only took the message as a parameter. However, users may want to push status or location information into XComs and so callbacks need access to the context (or the XComs, but context is more general). This commit changes the code to pass the context.
NOTE: This is a **BREAKING CHANGE**.
Closes #43361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add context to Azure Service Bus Message callback [airflow]
Posted by "perry2of5 (via GitHub)" <gi...@apache.org>.
perry2of5 commented on PR #43370:
URL: https://github.com/apache/airflow/pull/43370#issuecomment-2438567782
Hmmm...the contributing guide says "update the provider.yaml file with the new (breaking) version of the provider", but the provider.yaml says "note that those versions are maintained by release manager - do not update them manually". I assume I don't need to change provider.yaml and that putting my comment about the breaking change in the PR is enough. Is that true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add context to Azure Service Bus Message callback [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43370:
URL: https://github.com/apache/airflow/pull/43370#issuecomment-2438361013
> NOTE: This is a **BREAKING CHANGE**.
Indeed. Can you please add a note on top of the changelog for the provider explaining the breaking change and what the users should do to switch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add context to Azure Service Bus Message callback [airflow]
Posted by "perry2of5 (via GitHub)" <gi...@apache.org>.
perry2of5 commented on PR #43370:
URL: https://github.com/apache/airflow/pull/43370#issuecomment-2439036737
Built provider locally and tested end-to-end in flow. Everything worked as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add context to Azure Service Bus Message callback [airflow]
Posted by "perry2of5 (via GitHub)" <gi...@apache.org>.
perry2of5 commented on PR #43370:
URL: https://github.com/apache/airflow/pull/43370#issuecomment-2438399082
Added note. Thanks for letting me know what to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add context to Azure Service Bus Message callback [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #43370:
URL: https://github.com/apache/airflow/pull/43370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add context to Azure Service Bus Message callback [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43370:
URL: https://github.com/apache/airflow/pull/43370#issuecomment-2438737708
Yes. No need to update versions, just update changelog - and any clarifications in our contributing docs are also very good contributions (just saying!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org