You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by andytaylor <gi...@git.apache.org> on 2017/02/06 16:02:40 UTC

[GitHub] activemq-artemis pull request #987: ARTEMIS-866 - add functionality to allow...

GitHub user andytaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/987

    ARTEMIS-866 - add functionality to allow live to vote for quorum on f\u2026

    \u2026ailure
    
    Also allow the quorum size to be configurable.
    
    https://issues.apache.org/jira/browse/ARTEMIS-866

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andytaylor/activemq-artemis live_vote

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/987.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #987
    
----
commit 7883b91a6e835aa9fe2a650dab93e9471f2439bd
Author: Andy Taylor <an...@gmail.com>
Date:   2017-02-06T16:01:09Z

    ARTEMIS-866 - add functionality to allow live to vote for quorum on failure
    
    Also allow the quorum size to be configurable.
    
    https://issues.apache.org/jira/browse/ARTEMIS-866

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #987: ARTEMIS-866 - add functionality to allow live t...

Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/987
  
    cheers @jbertram Ive fixed both


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #987: ARTEMIS-866 - add functionality to allow live t...

Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/987
  
    I'm still hitting a checkstyle issue when I do the PR check locally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #987: ARTEMIS-866 - add functionality to allow live t...

Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/987
  
    Also, your commit message doesn't follow the 50/72 format.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #987: ARTEMIS-866 - add functionality to allow...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/987


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #987: ARTEMIS-866 - add functionality to allow live t...

Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/987
  
    tests fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---