You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/23 16:48:01 UTC
[GitHub] [pulsar] heesung-sn opened a new pull request, #17828: [fix][tableview] fixed ack failure in ReaderImpl due to null messageI…
heesung-sn opened a new pull request, #17828:
URL: https://github.com/apache/pulsar/pull/17828
This PR is a cherry-pick from the master requested by https://github.com/apache/pulsar/pull/17728#issuecomment-1255772187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 merged pull request #17828: [fix][tableview] Fixed ack failure in ReaderImpl due to null messageId
Posted by GitBox <gi...@apache.org>.
Jason918 merged PR #17828:
URL: https://github.com/apache/pulsar/pull/17828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] heesung-sn commented on a diff in pull request #17828: [fix][tableview] Fixed ack failure in ReaderImpl due to null messageId
Posted by GitBox <gi...@apache.org>.
heesung-sn commented on code in PR #17828:
URL: https://github.com/apache/pulsar/pull/17828#discussion_r979271694
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TableViewTest.java:
##########
@@ -222,7 +222,6 @@ public void testPublishNullValue() throws Exception {
assertEquals(tv.get("key2"), "value2");
}
-
Review Comment:
I see an internal data structure change for the `reader` member in TableView. The `testAck` in the master branch will fail in 2.10 branch.
2.10
`private final ConcurrentMap<String, Reader<T>> readers;`
master
`private final CompletableFuture<Reader<T>> reader;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] heesung-sn commented on a diff in pull request #17828: [fix][tableview] Fixed ack failure in ReaderImpl due to null messageId
Posted by GitBox <gi...@apache.org>.
heesung-sn commented on code in PR #17828:
URL: https://github.com/apache/pulsar/pull/17828#discussion_r979271694
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TableViewTest.java:
##########
@@ -222,7 +222,6 @@ public void testPublishNullValue() throws Exception {
assertEquals(tv.get("key2"), "value2");
}
-
Review Comment:
I see an internal data structure change for the `reader` member in TableView. The `testAck` in the master branch will fail in 2.10 branch.
2.10
`private final ConcurrentMap<String, Reader<T>> readers;`
master
`private final CompletableFuture<Reader<T>> reader;`
We could add the test when merging this update in branch-2.10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a diff in pull request #17828: [fix][tableview] Fixed ack failure in ReaderImpl due to null messageId
Posted by GitBox <gi...@apache.org>.
Jason918 commented on code in PR #17828:
URL: https://github.com/apache/pulsar/pull/17828#discussion_r979187375
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TableViewTest.java:
##########
@@ -222,7 +222,6 @@ public void testPublishNullValue() throws Exception {
assertEquals(tv.get("key2"), "value2");
}
-
Review Comment:
We don't need the `testAck` method in #17728 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #17828: [fix][tableview] Fixed ack failure in ReaderImpl due to null messageId
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #17828:
URL: https://github.com/apache/pulsar/pull/17828#issuecomment-1256897462
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a diff in pull request #17828: [fix][tableview] Fixed ack failure in ReaderImpl due to null messageId
Posted by GitBox <gi...@apache.org>.
Jason918 commented on code in PR #17828:
URL: https://github.com/apache/pulsar/pull/17828#discussion_r979350792
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TableViewTest.java:
##########
@@ -222,7 +222,6 @@ public void testPublishNullValue() throws Exception {
assertEquals(tv.get("key2"), "value2");
}
-
Review Comment:
> We could add the test when merging this update in branch-2.10.
I see, it's introduced in https://github.com/apache/pulsar/pull/15589, which is a refactor and not necessary for patch releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17828: [fix][tableview] fixed ack failure in ReaderImpl due to null messageI…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17828:
URL: https://github.com/apache/pulsar/pull/17828#issuecomment-1256437146
@heesung-sn Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org