You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@johnzon.apache.org by "jeanouii (via GitHub)" <gi...@apache.org> on 2023/04/24 18:05:36 UTC

[GitHub] [johnzon] jeanouii commented on pull request #101: TCKs in github actions

jeanouii commented on PR #101:
URL: https://github.com/apache/johnzon/pull/101#issuecomment-1520608104

   I'm against skipping the TCK. They are part of the test suite and I want to know if a commit introduces a backward compatibility issue or a TCK issue.
   
   > skipped them by default to not break the build just because of a tck failure
   
   This is exactly why tests are useful.
   If the build is red, we have 2 options:
   - fix our code 
   - fix or exclude the related test
   
   Either way, it can't be a silent decision/action.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org