[jira] [Commented] (IGNITE-14681) Calcite engine. Extend return type of sum() aggregate function

["Taras Ledkov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-14681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408815#comment-17408815 ] 

Taras Ledkov commented on IGNITE-14681:
---------------------------------------

The issue depends on CALCITE-4652.
The {{AggregateExpandDistinctAggregatesRule}} is copied from calcite master to the Ignite codebase until upgrade calcite version (IGNITE-15426).

> Calcite engine. Extend return type of sum() aggregate function
> --------------------------------------------------------------
>
>                 Key: IGNITE-14681
>                 URL: https://issues.apache.org/jira/browse/IGNITE-14681
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Aleksey Plekhanov
>            Assignee: Taras Ledkov
>            Priority: Major
>              Labels: calcite2-required, calcite3-required
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, {{sum()}} aggregate function returns the same type as an argument and there can be an overflow.
> For example, query:
> {noformat}
> SELECT SUM(i::SMALLINT) FROM (SELECT 32000 as i UNION ALL SELECT 32000){noformat}
> Returns {{-1536}}.
> Perhaps it would be better to return an extended type as some other vendors do.
> For example, PostgreSQL returns {{bigint}} for {{smallint}} or {{int}} arguments, {{numeric}} for {{bigint}} arguments, {{double precision}} for floating-point arguments. MySQL returns a {{DECIMAL}} value for exact-value arguments ({{INTEGER}} or {{DECIMAL}}), and a {{DOUBLE}} value for approximate-value arguments ({{FLOAT}} or {{DOUBLE}})
> Affected tests:
> {{modules/calcite/src/test/sql/aggregate/aggregates/test_sum.test_ignore}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)