You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/23 21:32:10 UTC
[GitHub] [nifi] FerrelBurn opened a new pull request #4426: Nifi 1.11.4 fix corrupt flow.xml.gz and add thread priority
FerrelBurn opened a new pull request #4426:
URL: https://github.com/apache/nifi/pull/4426
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
fix corrupt flow.xml.gz and add thread priority; fixes an unreported bug
Delegate writing flow.xml.gz to FlowConfigurationDAO …
Before initial synchronizing flow.xml.gz, check for valid local …
Lower thread priority of timer-driven and event-driven data thread pool …
Add isValidXml to validate flow.xml.gz
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [NO] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [NO] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [YES] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [NO] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [YES] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [NO] Have you written or updated unit tests to verify your changes?
- [YES] Have you verified that the full build is successful on JDK 8?
- [YES] Have you verified that the full build is successful on JDK 11?
- [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [NA] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [NA] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [NO] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4426: Nifi 1.11.4 fix corrupt flow.xml.gz and add thread priority
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4426:
URL: https://github.com/apache/nifi/pull/4426#issuecomment-667147545
Hello. Looks like this PR is not properly rebased against main. Please ensure that you file a Jira that explains what the concern is and rebase against `main` so that only your new commits are provided in the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt closed pull request #4426: Nifi 1.11.4 fix corrupt flow.xml.gz and add thread priority
Posted by GitBox <gi...@apache.org>.
joewitt closed pull request #4426:
URL: https://github.com/apache/nifi/pull/4426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] phuthientran commented on pull request #4426: Nifi 1.11.4 fix corrupt flow.xml.gz and add thread priority
Posted by GitBox <gi...@apache.org>.
phuthientran commented on pull request #4426:
URL: https://github.com/apache/nifi/pull/4426#issuecomment-730039682
@joewitt , I'm the developer who implemented this fix and other fixes and improvements for our company, Zapata Technology. We'd to contribute those to the NiFi project but are not sure what the proper procedure is. We have the code for NiFi 1.11.4 but would like to have them in the main branch for inclusion in the future NiFi release. Can you give us some guidance? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #4426: Nifi 1.11.4 fix corrupt flow.xml.gz and add thread priority
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4426:
URL: https://github.com/apache/nifi/pull/4426#issuecomment-667315756
Very difficult to tell what this is associated with. Please ensure a JIRA exists, is tagged, and the commit included for review is just what needs to be considered. Closing for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org