You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "zohrehasadi00 (via GitHub)" <gi...@apache.org> on 2026/01/13 10:11:27 UTC

[PR] [SYSTEMDS-3421] Add serialization support for UDF encoders [systemds]

zohrehasadi00 opened a new pull request, #2397:
URL: https://github.com/apache/systemds/pull/2397

   Adds UDF encoder type to ColumnEncoder enum and EncoderFactory -> UDF encoders can be created/serialized.
   Implements readExternal/writeExternal for ColumnEncoderUDF to persist function name and domain size.
   Adds a regression test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYSTEMDS-3421] Add serialization support for UDF encoders [systemds]

Posted by "janniklinde (via GitHub)" <gi...@apache.org>.
janniklinde commented on PR #2397:
URL: https://github.com/apache/systemds/pull/2397#issuecomment-3907254215

   Thanks for the PR @zohrehasadi00. I'm not really familiar with this issue but I don't see how this fully addresses issue 3421? @Baunsgaard do you have any comments on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYSTEMDS-3421] Add serialization support for UDF encoders [systemds]

Posted by "zohrehasadi00 (via GitHub)" <gi...@apache.org>.
zohrehasadi00 commented on PR #2397:
URL: https://github.com/apache/systemds/pull/2397#issuecomment-3864721414

   @janniklinde This is my first time contributing to an open-source project voluntarily. Should I do anything from my side, or will someone review the PR automatically through the queue or sth? tnx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYSTEMDS-3421] Add serialization support for UDF encoders [systemds]

Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on code in PR #2397:
URL: https://github.com/apache/systemds/pull/2397#discussion_r2812322204


##########
src/main/java/org/apache/sysds/runtime/transform/encode/EncoderFactory.java:
##########
@@ -276,19 +278,21 @@ public static ColumnEncoder createInstance(int type) {
 			case Bin:
 				return new ColumnEncoderBin();
 			case Dummycode:
-				return new ColumnEncoderDummycode();
-			case FeatureHash:
-				return new ColumnEncoderFeatureHash();
-			case PassThrough:
-				return new ColumnEncoderPassThrough();
-			case Recode:
-				return new ColumnEncoderRecode();
-			case WordEmbedding:
-				return new ColumnEncoderWordEmbedding();
-			case BagOfWords:
-				return new ColumnEncoderBagOfWords();
-			default:
-				throw new DMLRuntimeException("Unsupported encoder type: " + etype);
+			return new ColumnEncoderDummycode();
+		case FeatureHash:
+			return new ColumnEncoderFeatureHash();
+		case PassThrough:
+			return new ColumnEncoderPassThrough();
+		case Recode:
+			return new ColumnEncoderRecode();
+		case WordEmbedding:
+			return new ColumnEncoderWordEmbedding();
+		case BagOfWords:
+			return new ColumnEncoderBagOfWords();
+		case UDF:
+			return new ColumnEncoderUDF();
+		default:
+			throw new DMLRuntimeException("Unsupported encoder type: " + etype);

Review Comment:
   Seems like the indentation is somehow changed. Should be fixed to highlight the new case you added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org