[jira] Commented: (QPID-1625) C++ tests need Linux-isms changed to build on Windows

["Steve Huston (JIRA)" <qp...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678391#action_12678391 ] 

Steve Huston commented on QPID-1625:
------------------------------------

Ok, will do. I've added alloca.h to qpid/sys in the qpid-1673 branch and will merge that in with the rest.

> C++ tests need Linux-isms changed to build on Windows
> -----------------------------------------------------
>
>                 Key: QPID-1625
>                 URL: https://issues.apache.org/jira/browse/QPID-1625
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker, C++ Client
>    Affects Versions: M4
>         Environment: Windows
>            Reporter: Steve Huston
>            Assignee: Steve Huston
>            Priority: Minor
>
> A number of the qpid/cpp/src/tests sources contain #includes that don't work on Windows. For example, <alloca.h>. In many cases, the referenced facilities exist on Windows but are accessed slightly differently. For example, this works on Windows where <alloca.h> is included:
> #ifdef _WIN32
> #  include <malloc.h>
> #  define alloc _alloc
> #else
> #  include <alloca.h>
> #endif
> I was thinking that, rather than add things to qpid/cpp/src/qpid/sys (platform-specific code for broker and client) that a sys directory be added to qpid/cpp/src/tests where things used just for the testing are placed. For example, there could be a tests/sys/alloca.h which contains, essentially, the ifdef block above.
> Thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org