svn commit: r1707329 - /pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/parser/PreflightParser.java

[ti...@apache.org]

Author: tilman
Date: Wed Oct  7 16:04:50 2015
New Revision: 1707329

URL: http://svn.apache.org/viewvc?rev=1707329&view=rev
Log:
PDFBOX-3008: close file after parsing to avoid memory leak

Modified:
    pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/parser/PreflightParser.java

Modified: pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/parser/PreflightParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/parser/PreflightParser.java?rev=1707329&r1=1707328&r2=1707329&view=diff
==============================================================================
--- pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/parser/PreflightParser.java (original)
+++ pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/parser/PreflightParser.java Wed Oct  7 16:04:50 2015
@@ -33,6 +33,7 @@ import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import javax.activation.DataSource;
 import javax.activation.FileDataSource;
+import org.apache.commons.io.IOUtils;
 import org.apache.pdfbox.cos.COSArray;
 import org.apache.pdfbox.cos.COSBase;
 import org.apache.pdfbox.cos.COSDictionary;
@@ -211,6 +212,11 @@ public class PreflightParser extends PDF
             addValidationError(new ValidationError(PreflightConstants.ERROR_SYNTAX_COMMON, e.getMessage()));
             throw new SyntaxValidationException(e, this.validationResult);
         }
+        finally
+        {
+            // TODO move file handling outside of the parser
+            IOUtils.closeQuietly(source);
+        }
         Format formatToUse = (format == null ? Format.PDF_A1B : format);
         createPdfADocument(formatToUse, config);
         createContext();