You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by su...@apache.org on 2019/05/17 10:06:23 UTC

[incubator-echarts] 02/02: Avoid async error if chart is disposed and tooltip is displayed delayed .

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch fix/fix-rotate-and-tooltip
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 6e0cd1f4c8da13aa6636bb51741d4873d6db005d
Author: sushuang <su...@gmail.com>
AuthorDate: Fri May 17 18:04:57 2019 +0800

    Avoid async error if chart is disposed and tooltip is displayed delayed .
---
 src/component/tooltip/TooltipView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/component/tooltip/TooltipView.js b/src/component/tooltip/TooltipView.js
index cd4e183..a745184 100644
--- a/src/component/tooltip/TooltipView.js
+++ b/src/component/tooltip/TooltipView.js
@@ -155,7 +155,7 @@ export default echarts.extendComponentView({
                 // Show tip next tick after other charts are rendered
                 // In case highlight action has wrong result
                 // FIXME
-                self.manuallyShowTip(tooltipModel, ecModel, api, {
+                !api.isDisposed() && self.manuallyShowTip(tooltipModel, ecModel, api, {
                     x: self._lastX,
                     y: self._lastY
                 });


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org