You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/27 06:40:05 UTC

[GitHub] [apisix-ingress-controller] chzhuo opened a new pull request #723: Bugfix: add tag omitempty for the fields in this data structure ApisixRouteHTTPMatchExpr

chzhuo opened a new pull request #723:
URL: https://github.com/apache/apisix-ingress-controller/pull/723


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   In the ApisixRoute CRD: 
   ![image](https://user-images.githubusercontent.com/10919124/139011884-e45bc91e-f578-4fe1-8c7e-bf1367f6336d.png)
   So the field `value` and `set` can't appear at the same time
   But the golang data structure will be marshal to `value: null` or `set: null`, this will cause CRD checking error
   
   - How to fix?
    Adding tag `omitempty` to this field 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #723: Bugfix: add tag omitempty for the fields in this data structure ApisixRouteHTTPMatchExpr

Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #723:
URL: https://github.com/apache/apisix-ingress-controller/pull/723


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #723: Bugfix: add tag omitempty for the fields in this data structure ApisixRouteHTTPMatchExpr

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #723:
URL: https://github.com/apache/apisix-ingress-controller/pull/723#issuecomment-965905498


   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org