[GitHub] piiswrong commented on a change in pull request #10864: Support for axis parameter in linalg.gemm

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #10864: Support for axis parameter in linalg.gemm
URL: https://github.com/apache/incubator-mxnet/pull/10864#discussion_r188392502
 
 

 ##########
 File path: src/operator/tensor/la_op.h
 ##########
 @@ -53,13 +54,17 @@ struct LaMatrixMacParam : public dmlc::Parameter<LaMatrixMacParam> {
     DMLC_DECLARE_FIELD(beta)
       .set_default(1.0)
       .describe("Scalar factor multiplied with C.");
+    DMLC_DECLARE_FIELD(axis)
+      .set_default(-2)
+      .describe("Axis corresponding to the matrix rows.");
 
 Review comment:
   This is a little confusing. Is it the rows of the resulting matrix?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services