You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Arno Unkrig (JIRA)" <ji...@apache.org> on 2007/10/04 20:34:51 UTC

[jira] Created: (NET-171) Improve MVSFTPEntryParser.java

Improve MVSFTPEntryParser.java
------------------------------

                 Key: NET-171
                 URL: https://issues.apache.org/jira/browse/NET-171
             Project: Commons Net
          Issue Type: Improvement
         Environment: MVS FTP server
            Reporter: Arno Unkrig


Hi there,

the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?


CU

Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Created: (NET-171) Improve MVSFTPEntryParser.java

Posted by he...@balcab.ch.
On Thursday 04 October 2007 20.34:51 Arno Unkrig (JIRA) wrote:
> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                  Key: NET-171
>                  URL: https://issues.apache.org/jira/browse/NET-171
>              Project: Commons Net
>           Issue Type: Improvement
>          Environment: MVS FTP server
>             Reporter: Arno Unkrig
>
>
> Hi there,
>
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP
> server, is a sad view... it's totally broken. 
where is it broken ?
Which version of commons.net are you using.
> I developed a custom 
> FTPEntryParser, which I can hook into the FtpClient (thank you for the
> highly customizable design). I'd like to donate it to COMMONS NET... who
> can I turn to?
>
>
> CU
>
> Arno Unkrig
Henrik


[jira] Commented: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Arno Unkrig (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533627 ] 

Arno Unkrig commented on NET-171:
---------------------------------

Also, I'd strongly recommend that FTPFile declare an (abstract?) method

    public String getModificationStamp()

, which returns a short string which is guaranteed to remain the same as long as the file is unmodified and is very probable to change if the file is modified. E.g. on a UNIX system, the modification stamp could be modification time plus file size; on MVS, it could be modification date plus modification level.

That would be a portable way to detect file changes on the FTP server.


CU

Arno

> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>         Attachments: FTPFileLoadlib.java, FTPFilePO.java, FTPFilePOMember.java, MvsFTPUtil.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Arno Unkrig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arno Unkrig updated NET-171:
----------------------------

    Attachment: MvsFTPUtil.java

> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>         Attachments: FTPFileLoadlib.java, FTPFilePO.java, FTPFilePOMember.java, MvsFTPUtil.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Arno Unkrig (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542220 ] 

Arno Unkrig commented on NET-171:
---------------------------------

Hi Rory and Henrik,

I was not aware of Henrik's MVS improvements for 2.0. Indeed they are exactly what I need! (Hence the overlap is total ;-) Actually, Henrik's implementation is much more complete since his understanding of the MVS file system mess is much more complete than mine. I more or less hacked the MVS FTP server behavior.

Henrik surely agrees that the 1.4.1 MVS parser is totally broken.

The only point where the solution that Henrik and Steve developed seems a bit too complicated is that they define SEVERAL parsers for the several listing formats of the MVS server, and a strategy to choose one of those. In contrast, I provide only ONE parser class that detects and parses ALL possible MVS listings. In other words: It is arguable whether the N listing formats should be parsed by N parser classes, or if the listing formats produced by the ONE server system MVS should be parsed by ONE parser class. But I'm not the net.commons expert, and I'd be happy to replace my home-grown MVS solution with the net.commons 2.0.

When will 2.0 be released? I cannot find a roadmap or anything. On the web site, everything is 1.4.1.


CU

Arno

> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>         Attachments: FTPFileLoadlib.java, FTPFilePO.java, FTPFilePOMember.java, MvsFTPUtil.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Rory Winston (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541641 ] 

Rory Winston commented on NET-171:
----------------------------------

Arno

Are you aware of the improvements to the MVS parser that Henrik has applied for the 2.0 release?

See this thread:

https://issues.apache.org/jira/browse/NET-99

Is there much overlap between your patches and Henrik's?



> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>         Attachments: FTPFileLoadlib.java, FTPFilePO.java, FTPFilePOMember.java, MvsFTPUtil.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Rory Winston (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rory Winston closed NET-171.
----------------------------

       Resolution: Fixed
    Fix Version/s: 2.0

> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>             Fix For: 2.0
>
>         Attachments: FTPFileLoadlib.java, FTPFilePO.java, FTPFilePOMember.java, MvsFTPUtil.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Rory Winston (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533204 ] 

Rory Winston commented on NET-171:
----------------------------------

If you have code you feel is worth contributing, attach it to this issue and I will review it.

> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Arno Unkrig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arno Unkrig updated NET-171:
----------------------------

    Attachment: FTPFilePO.java

> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>         Attachments: FTPFileLoadlib.java, FTPFilePO.java, FTPFilePOMember.java, MvsFTPUtil.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Arno Unkrig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arno Unkrig updated NET-171:
----------------------------

    Attachment: FTPFileLoadlib.java

> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>         Attachments: FTPFileLoadlib.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Arno Unkrig (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533462 ] 

Arno Unkrig commented on NET-171:
---------------------------------

Your wish is my command ;-)

"\MVSFTP\MvsFTPUtil" is the entry point.


CU

Arno

> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>         Attachments: FTPFileLoadlib.java, FTPFilePO.java, FTPFilePOMember.java, MvsFTPUtil.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (NET-171) Improve MVSFTPEntryParser.java

Posted by "henrik sorensen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539830 ] 

henrik sorensen commented on NET-171:
-------------------------------------

where is it broken ?
Which version of commons.net are you using.
Henrik



> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>         Attachments: FTPFileLoadlib.java, FTPFilePO.java, FTPFilePOMember.java, MvsFTPUtil.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Arno Unkrig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arno Unkrig updated NET-171:
----------------------------

    Attachment: FTPFilePOMember.java

> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>         Attachments: FTPFileLoadlib.java, FTPFilePO.java, FTPFilePOMember.java, MvsFTPUtil.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (NET-171) Improve MVSFTPEntryParser.java

Posted by "Arno Unkrig (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NET-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541466 ] 

Arno Unkrig commented on NET-171:
---------------------------------

The current implementation does not strip the "title line", and it does not parse the entries correctly. Also, the MVS FTP server produces (at least) two totally different directory listings, depending on which directory list.

I'm using commons-net-1.4.1.jar, which requires jakarta-oro-2.0.8.jar.


CU

Arno

> Improve MVSFTPEntryParser.java
> ------------------------------
>
>                 Key: NET-171
>                 URL: https://issues.apache.org/jira/browse/NET-171
>             Project: Commons Net
>          Issue Type: Improvement
>         Environment: MVS FTP server
>            Reporter: Arno Unkrig
>         Attachments: FTPFileLoadlib.java, FTPFilePO.java, FTPFilePOMember.java, MvsFTPUtil.java
>
>
> Hi there,
> the "MVSFTPEntryParser" who parses the output of an FTP LIST of an MVS FTP server, is a sad view... it's totally broken. I developed a custom FTPEntryParser, which I can hook into the FtpClient (thank you for the highly customizable design). I'd like to donate it to COMMONS NET... who can I turn to?
> CU
> Arno Unkrig

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.