You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/17 11:56:50 UTC
[GitHub] [airflow] madden1706 opened a new pull request #14849: Update metadataConnection to be postgres container default.
madden1706 opened a new pull request #14849:
URL: https://github.com/apache/airflow/pull/14849
The local postgres container password default does not seem to be correct.
Updated this so the airflow containers will be able to access the database.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ianstanton commented on pull request #14849: Update metadataConnection to be postgres container default.
Posted by GitBox <gi...@apache.org>.
ianstanton commented on pull request #14849:
URL: https://github.com/apache/airflow/pull/14849#issuecomment-801824970
@madden1706 Could you provide steps to reproduce and environment details? I am able to run successfully with default values on a GKE cluster. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ianstanton commented on pull request #14849: Update metadataConnection to be postgres container default.
Posted by GitBox <gi...@apache.org>.
ianstanton commented on pull request #14849:
URL: https://github.com/apache/airflow/pull/14849#issuecomment-801197495
Hmm that value should be set here: https://github.com/apache/airflow/blob/2a2adb3f94cc165014d746102e12f9620f271391/chart/values.yaml#L698
I'll take a closer look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madden1706 commented on pull request #14849: Update metadataConnection to be postgres container default.
Posted by GitBox <gi...@apache.org>.
madden1706 commented on pull request #14849:
URL: https://github.com/apache/airflow/pull/14849#issuecomment-801840637
Hi, I've deleted and recreated my minikube cluster. Seems to have solved - I'll close this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14849: Update metadataConnection to be postgres container default.
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14849:
URL: https://github.com/apache/airflow/pull/14849#issuecomment-801155709
@ianstanton related to switching the postgres subchart maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14849: Update metadataConnection to be postgres container default.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14849:
URL: https://github.com/apache/airflow/pull/14849#issuecomment-801023851
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madden1706 closed pull request #14849: Update metadataConnection to be postgres container default.
Posted by GitBox <gi...@apache.org>.
madden1706 closed pull request #14849:
URL: https://github.com/apache/airflow/pull/14849
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org