You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Sunstreaker (via GitHub)" <gi...@apache.org> on 2023/04/11 16:46:29 UTC
[GitHub] [eventmesh] Sunstreaker opened a new pull request, #3696: [ISSUE #2980] Can be replaced with single 'Map.computeIfAbsent' method call[UnSubscribeProcessor]
Sunstreaker opened a new pull request, #3696:
URL: https://github.com/apache/eventmesh/pull/3696
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #2980
### Motivation
Enhancement Request
### Modifications
Substituted Map.get & Map.put combined logic with Map.computeIfAbsent in UnSubscribeProcessor.java
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
- If a feature is not applicable for documentation, explain why? - code refactor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Sunstreaker commented on pull request #3696: [ISSUE #2980] Can be replaced with single 'Map.computeIfAbsent' method call[UnSubscribeProcessor]
Posted by "Sunstreaker (via GitHub)" <gi...@apache.org>.
Sunstreaker commented on PR #3696:
URL: https://github.com/apache/eventmesh/pull/3696#issuecomment-1506224761
@Alonexc Thank you. Possible to merge this code to master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3696: [ISSUE #2980] Can be replaced with single 'Map.computeIfAbsent' method call[UnSubscribeProcessor]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3696:
URL: https://github.com/apache/eventmesh/pull/3696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3696: [ISSUE #2980] Can be replaced with single 'Map.computeIfAbsent' method call[UnSubscribeProcessor]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3696:
URL: https://github.com/apache/eventmesh/pull/3696#issuecomment-1504517272
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3696?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3696](https://codecov.io/gh/apache/eventmesh/pull/3696?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d54af84) into [master](https://codecov.io/gh/apache/eventmesh/commit/1e38fd13a0b8983ee9761fe62553803c6a182266?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e38fd1) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head d54af84 differs from pull request most recent head a624dca. Consider uploading reports for the commit a624dca to get more accurate results
```diff
@@ Coverage Diff @@
## master #3696 +/- ##
============================================
- Coverage 13.76% 13.76% -0.01%
- Complexity 1291 1292 +1
============================================
Files 571 571
Lines 29236 29226 -10
Branches 2884 2871 -13
============================================
- Hits 4024 4022 -2
+ Misses 24838 24832 -6
+ Partials 374 372 -2
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../protocol/http/processor/UnSubscribeProcessor.java](https://codecov.io/gh/apache/eventmesh/pull/3696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvVW5TdWJzY3JpYmVQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
... and [8 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3696/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org