You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Michael DeWulf (JIRA)" <ji...@apache.org> on 2016/08/11 18:12:23 UTC

[jira] [Commented] (AIRFLOW-409) Add option to not configure logging (keep existing loggers)

    [ https://issues.apache.org/jira/browse/AIRFLOW-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417695#comment-15417695 ] 

Michael DeWulf commented on AIRFLOW-409:
----------------------------------------

More generally, I think it would be better if the root logger were never modified (other than being added to).  That way, airflow is polite and defers to the parent application settings.  E.g. airflow should never call `logging.root.handlers = []` or `root.setLevel(<some new log level>)`.

> Add option to not configure logging (keep existing loggers)
> -----------------------------------------------------------
>
>                 Key: AIRFLOW-409
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-409
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: logging
>            Reporter: Michael DeWulf
>            Assignee: Michael DeWulf
>            Priority: Minor
>
> The airflow.settings module calls [configure_logging|https://github.com/apache/incubator-airflow/blob/b18c9959142f3f1e2cb031c8709225af01192e32/airflow/settings.py#L127], which removes all existing loggers and installs the basic logging config.  For projects with loggers already configured, it would be nice if this could be disabled.
> It seems like we could add a config option which is checked before logging is configured by airflow.  If the option is false, then logging would not be configured.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)