You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2022/04/21 15:55:31 UTC

[GitHub] [knox] pzampino commented on a diff in pull request #561: KNOX-2735 Add support for group info inclusion in tokens to the KnoxShell client

pzampino commented on code in PR #561:
URL: https://github.com/apache/knox/pull/561#discussion_r855343918


##########
gateway-shell/src/test/java/org/apache/knox/gateway/shell/knox/token/TokenTest.java:
##########
@@ -42,24 +43,28 @@ public class TokenTest {
 
   @Test
   public void testTokenWithNoDoAs() {
-    testToken(false, null);
+    testToken(false, null, false);

Review Comment:
   I would like us continue to include tests for the original method signature without the new boolean for including groups. This will help prove backward compatibility and validate the default behavior to NOT include the group info.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org