You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/11/13 22:04:09 UTC
[kudu-CR] MiniHms: log HMS thread stacks when startup times out
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8534
to review the following change.
Change subject: MiniHms: log HMS thread stacks when startup times out
......................................................................
MiniHms: log HMS thread stacks when startup times out
We're seeing instances where the HMS can take more than 60 seconds to
startup on test machines. This commit changes MiniHms to send SIGQUIT to
the HMS on timeout, in order to capture thread stack traces of the slow
process.
Change-Id: Ifefb3b16ef097412604d555d5c2118aca3d998a9
---
M src/kudu/hms/mini_hms.cc
1 file changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/8534/1
--
To view, visit http://gerrit.cloudera.org:8080/8534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifefb3b16ef097412604d555d5c2118aca3d998a9
Gerrit-Change-Number: 8534
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] MiniHms: log HMS thread stacks when startup times out
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8534 )
Change subject: MiniHms: log HMS thread stacks when startup times out
......................................................................
MiniHms: log HMS thread stacks when startup times out
We're seeing instances where the HMS can take more than 60 seconds to
startup on test machines. This commit changes MiniHms to send SIGQUIT to
the HMS on timeout, in order to capture thread stack traces of the slow
process.
Change-Id: Ifefb3b16ef097412604d555d5c2118aca3d998a9
Reviewed-on: http://gerrit.cloudera.org:8080/8534
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/hms/mini_hms.cc
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifefb3b16ef097412604d555d5c2118aca3d998a9
Gerrit-Change-Number: 8534
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] MiniHms: log HMS thread stacks when startup times out
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8534 )
Change subject: MiniHms: log HMS thread stacks when startup times out
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifefb3b16ef097412604d555d5c2118aca3d998a9
Gerrit-Change-Number: 8534
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 13 Nov 2017 22:32:53 +0000
Gerrit-HasComments: No